Skip to content

Commit 92cd722

Browse files
ansible_module_requires_too_much_perms_just_for_autoscaling_managemen… (#761)
* ansible_module_requires_too_much_perms_just_for_autoscaling_management_so_replacing_with_aws_cli_from_role * fix condition * asg_management_workaround_improve_fix_conditions * remove extra line
1 parent decb6fb commit 92cd722

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

roles/deploy_code/tasks/cleanup.yml

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -252,13 +252,8 @@
252252
when: task_result.rc != 0
253253
block:
254254
- name: Resume all autoscale processes on ASG.
255-
amazon.aws.autoscaling_group:
256-
name: "{{ asg_management.name }}"
257-
region: "{{ asg_management.region }}"
258-
profile: "{{ asg_management.profile | default(omit) }}"
259-
suspend_processes: []
260-
delegate_to: localhost
261-
run_once: true
255+
ansible.builtin.include_role:
256+
name: asg_management
262257
when:
263258
- asg_management.name is defined
264259
- asg_management.name | length > 0
@@ -279,7 +274,7 @@
279274
when:
280275
- asg_management.name is defined
281276
- asg_management.name | length > 0
282-
- asg_management.refresh_asg_instances
277+
- asg_management.refresh_asg_instances | default(true)
283278

284279
- name: Start any services we stopped if the image re-mounting failed and ASG management is disabled.
285280
ansible.builtin.service:
@@ -292,7 +287,7 @@
292287
when:
293288
- deploy_code.service_action == "stop"
294289
- deploy_code.services | length > 0
295-
- not asg_management.refresh_asg_instances or asg_management.name is not defined
290+
- asg_management.refresh_asg_instances is not defined or not asg_management.refresh_asg_instances or asg_management.name is not defined
296291
# End of the squashFS block.
297292

298293
- name: Trigger an infrastructure rebuild.

0 commit comments

Comments
 (0)