Bug fixes pr 2.x (#2717)

* Fixing installer variable bug.

* Fixing tests for external PRs.

* Testing with a fork.

* Adding repo owner's username into installer string.

* Refactoring config repo detection to simplify.

* No longer permitted to use an integer as a truthy value.

* No longer permitted to use existence check as a truthy value.

* Can't see a reason why linotp var shouldn't be a boolean.

* No longer permitted to use existence check as a truthy value.

* Fixing truthy errors in ce_deploy role.

* No longer permitted to use an integer as a truthy value.

* Updating clamav command to use flock avoiding duplicate processes running.

* More truthy length fixes.

* Fixing more LDAP role truthy issues.

* Slight block refactor for LDAP.

* DN length check should not be negated.

* Forgot to add the length filter.

* Another boolean Ansible 12 error in AMI role.

* ALB port must be cast as a string for RedirectAction.

* Setting the correct Jinja filter, it's string, not str.

* Fixing more Ansible 12 length issues in autoscale role.

* Simplifying ASG role by refactoring into blocks.

* Further simplifying ASG CloudFront block.

* Scaling rules refactor needs work.

* Scaling policies list needs to be defined in case it is empty and we try to concatenate.

* Enhancing installer to accept an Ansible version and putting Ansible 12 back into GitHub Actions containers.

* Trying a different approach to defaulting the venv username.

* Removing default() filter from python_pip_packages role.

* Fixing up the ce_ansible role for Ansible 12.

* Removing unnecessary from_json filter from CloudFront acc ID lookup.

* Trying to fix AWS standalone builds.

* Fixing standalone EC2 playbooks.

* Adding hostname print out for debug.

* Adding back in the hostname check.

* Fixing AWS hostname variable in comparisons.

* Trying to find a hostname variation that meets all requirements.

* Adding both hostnames to ec2.yml.

Author: gregharvey

plays/aws_ec2_standalone/ec2.yml

@@ -1,6 +1,6 @@
 ---
 # First step. Spin up a "blank" instance and add the controller user and Ansible via user-data.
-- hosts: "{{ _aws_resource_name }}"
+- hosts: "{{ _aws_resource_name }}, _{{ _aws_resource_name | regex_replace('-', '_') }}"
   connection: local
   become: false
 

plays/aws_ec2_standalone/launch.yml

@@ -27,6 +27,6 @@
       ansible.builtin.add_host:
         name: "{{ _aws_resource_name }}"
         groups: "_new_servers"
-      when: _aws_hostname | length == 0
+      when: _aws_hostname|length == 0
     - ansible.builtin.import_role:
         name: _exit

roles/aws/aws_ec2_with_eip/tasks/main.yml

@@ -17,6 +17,10 @@
   with_inventory_hostnames:
     - "_{{ aws_ec2_with_eip.hostname|regex_replace('-', '_') }}"
 
+- name: Check the hostname.
+  ansible.builtin.debug:
+    msg: "Ansible hostname set to: {{ _aws_hostname }}"
+
 # Subnet ID is stored in ce-provision's data directory
 - name: Ensure server data directory exists.
   ansible.builtin.file:
@@ -105,7 +109,7 @@
     msg: "No AMI found using the provided filters, exiting!"
   when: _aws_ec2_with_eip_ami_images.images | length == 0
 
-# Do not create an instance if _aws_hostname is not an EC2 generated address unless `force: true`
+# Create an instance if _aws_hostname is set (it cannot be unless there is an EC2 generated address in a tagged hostgroup) unless `force: true`
 - name: Create new EC2 instance.
   amazon.aws.ec2_instance:
     profile: "{{ aws_ec2_with_eip.aws_profile }}"