🤖 fix: remove timeout from ask_user_question tool

The 30-minute timeout was too aggressive - users may step away and come
back later. The tool now waits indefinitely for user input.

It can still be canceled via:
- User typing a chat message
- Stream interruption (abort signal)
- Workspace cleanup

Signed-off-by: Thomas Kosiewski <[email protected]>

---
_Generated with `mux`_

Change-Id: I3e5e5e9f697cc07ad8fb1cc854562d2e4b1111bf

Author: ThomasK33

src/node/services/askUserQuestionManager.test.ts

@@ -16,7 +16,7 @@ const QUESTIONS = [
 
 describe("AskUserQuestionManager", () => {
   it("resolves when answered", async () => {
-    const manager = new AskUserQuestionManager({ timeoutMs: 1000 });
+    const manager = new AskUserQuestionManager();
 
     const promise = manager.registerPending("ws", "tool-1", [...QUESTIONS]);
     manager.answer("ws", "tool-1", { "What should we do?": "A" });
@@ -27,7 +27,7 @@ describe("AskUserQuestionManager", () => {
   });
 
   it("rejects when canceled", async () => {
-    const manager = new AskUserQuestionManager({ timeoutMs: 1000 });
+    const manager = new AskUserQuestionManager();
 
     const promise = manager.registerPending("ws", "tool-1", [...QUESTIONS]);
 
@@ -43,7 +43,7 @@ describe("AskUserQuestionManager", () => {
   });
 
   it("tracks latest pending per workspace", async () => {
-    const manager = new AskUserQuestionManager({ timeoutMs: 1000 });
+    const manager = new AskUserQuestionManager();
 
     const promise1 = manager.registerPending("ws", "tool-1", [...QUESTIONS]);
     await new Promise((r) => setTimeout(r, 5));
@@ -64,22 +64,4 @@ describe("AskUserQuestionManager", () => {
     expect(error1).toBeInstanceOf(Error);
     expect(error2).toBeInstanceOf(Error);
   });
-
-  it("times out and cleans up", async () => {
-    const manager = new AskUserQuestionManager({ timeoutMs: 10 });
-
-    const promise = manager.registerPending("ws", "tool-1", [...QUESTIONS]);
-
-    let error: unknown;
-    try {
-      await promise;
-      throw new Error("Expected promise to reject");
-    } catch (err) {
-      error = err;
-    }
-
-    expect(error).toBeInstanceOf(Error);
-    expect((error as Error).message).toContain("Timed out");
-    expect(manager.getLatestPending("ws")).toBeNull();
-  });
 });

src/node/services/askUserQuestionManager.ts

@@ -11,16 +11,10 @@ interface PendingAskUserQuestionInternal extends PendingAskUserQuestion {
   createdAt: number;
   resolve: (answers: Record<string, string>) => void;
   reject: (error: Error) => void;
-  timeoutId: ReturnType<typeof setTimeout>;
 }
 
 export class AskUserQuestionManager {
   private pendingByWorkspace = new Map<string, Map<string, PendingAskUserQuestionInternal>>();
-  private readonly timeoutMs: number;
-
-  constructor(options?: { timeoutMs?: number }) {
-    this.timeoutMs = options?.timeoutMs ?? 30 * 60 * 1000; // 30 minutes
-  }
 
   registerPending(
     workspaceId: string,
@@ -38,23 +32,12 @@ export class AskUserQuestionManager {
     );
 
     return new Promise<Record<string, string>>((resolve, reject) => {
-      const timeoutId = setTimeout(() => {
-        this.cancel(workspaceId, toolCallId, "Timed out waiting for user answers");
-      }, this.timeoutMs);
-
       const entry: PendingAskUserQuestionInternal = {
         toolCallId,
         questions,
         createdAt: Date.now(),
-        resolve: (answers) => {
-          clearTimeout(timeoutId);
-          resolve(answers);
-        },
-        reject: (error) => {
-          clearTimeout(timeoutId);
-          reject(error);
-        },
-        timeoutId,
+        resolve,
+        reject,
       };
 
       workspaceMap.set(toolCallId, entry);