Skip to content

Commit 8cdc540

Browse files
committed
feature(package) add @cloudcmd/create-element
1 parent c6b952d commit 8cdc540

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

lib/smalltalk.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ require('../css/smalltalk.css');
44

55
const currify = require('currify/legacy');
66
const store = require('fullstore/legacy');
7+
const createElement = require('@cloudcmd/create-element');
78

89
const keyDown = currify(keyDown_);
910
const remove = bind(removeEl, '.smalltalk');
@@ -90,7 +91,6 @@ function showDialog(title, msg, value, buttons, options) {
9091
const ok = store();
9192
const cancel = store();
9293

93-
const dialog = document.createElement('div');
9494
const closeButtons = [
9595
'cancel',
9696
'close',
@@ -105,12 +105,12 @@ function showDialog(title, msg, value, buttons, options) {
105105
cancel(noCancel ? empty : reject);
106106
});
107107

108-
const tmpl = getTemplate(title, msg, value, buttons);
108+
const innerHTML = getTemplate(title, msg, value, buttons);
109109

110-
dialog.innerHTML = tmpl;
111-
dialog.className = 'smalltalk';
112-
113-
document.body.appendChild(dialog);
110+
const dialog = createElement('div', {
111+
innerHTML,
112+
className: 'smalltalk',
113+
});
114114

115115
find(dialog, ['ok', 'input']).forEach((el) =>
116116
el.focus()

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@
6969
"wraptile": "^2.0.0"
7070
},
7171
"dependencies": {
72+
"@cloudcmd/create-element": "^1.0.0",
7273
"currify": "^2.0.3",
7374
"fullstore": "^1.0.0"
7475
}

test/smalltalk.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1058,6 +1058,8 @@ function getCreateElement(el = {}) {
10581058
const querySelector = sinon.stub();
10591059
const addEventListener = sinon.stub();
10601060

1061+
el.dataset = {};
1062+
10611063
if (!el.querySelector)
10621064
el.querySelector = querySelector;
10631065

0 commit comments

Comments
 (0)