Skip to content

chore(docs): Toolbar engineering docs #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 1, 2025
Merged

chore(docs): Toolbar engineering docs #715

merged 5 commits into from
Dec 1, 2025

Conversation

@jaikamat
Copy link
Contributor

@jaikamat jaikamat commented Nov 20, 2025

Summary

Creates the engineering docs

@jaikamat jaikamat requested a review from a team November 20, 2025 19:31
@jaikamat jaikamat self-assigned this Nov 20, 2025
@jaikamat jaikamat requested review from ByronDWall, ddouglasz, misama-ct, stephsprinkle, tylermorrisford and valoriecarli and removed request for a team November 20, 2025 19:31
@jaikamat jaikamat added the documentation Improvements or additions to documentation label Nov 20, 2025
@changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 03ed4ca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
nimbus-documentation Ready Ready Preview Comment Dec 1, 2025 7:47pm
nimbus-storybook Ready Ready Preview Comment Dec 1, 2025 7:47pm

tylermorrisford
tylermorrisford approved these changes Nov 25, 2025
View reviewed changes
Copy link
Contributor

@tylermorrisford tylermorrisford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed one of the examples that I found confusing, otherwise LGTM

misama-ct
misama-ct approved these changes Nov 26, 2025
View reviewed changes
@jaikamat jaikamat merged commit 8a6aafe into main Dec 1, 2025
8 checks passed
@jaikamat jaikamat deleted the CRAFT-1980 branch December 1, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tylermorrisford tylermorrisford tylermorrisford approved these changes

@misama-ct misama-ct misama-ct approved these changes

@stephsprinkle stephsprinkle Awaiting requested review from stephsprinkle stephsprinkle was automatically assigned from commercetools/craft-team-fe-tag-all

@ddouglasz ddouglasz Awaiting requested review from ddouglasz ddouglasz was automatically assigned from commercetools/craft-team-fe-tag-all

@valoriecarli valoriecarli Awaiting requested review from valoriecarli valoriecarli was automatically assigned from commercetools/craft-team-fe-tag-all

@ByronDWall ByronDWall Awaiting requested review from ByronDWall ByronDWall was automatically assigned from commercetools/craft-team-fe-tag-all

Assignees

@jaikamat jaikamat

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jaikamat @tylermorrisford @misama-ct