clang comments

Signed-off-by: AdityaPandeyCN <[email protected]>

Author: AdityaPandeyCN

src/ramcore/RAMNTupleView.cxx

@@ -1,9 +1,11 @@
 #include "ramcore/RAMNTupleView.h"
+
 #include <cstdint>
-#include <iostream>
-#include <string>
 #include <cstring>
+#include <iostream>
 #include <limits>
+#include <string>
+
 #include <ROOT/RNTuple.hxx>
 #include <ROOT/RNTupleReader.hxx>
 #include <ROOT/RNTupleView.hxx>
@@ -177,7 +179,8 @@ Long64_t ramntupleview(const char *file, const char *query, bool cache, bool per
    }
 
    stopwatch.Print();
-   printf("Found %lld records in region %s\n", static_cast<long long>(count), query ? query : "");
+   std::cout << "Found " << static_cast<long long>(count) << " records in region "
+             << (query ? query : "") << std::endl;
    return count;
 }
 

src/ramcore/SamToNTuple.cxx

@@ -13,6 +13,7 @@
 #include <TFile.h>
 #include <TROOT.h>
 
+#include <cstdint>
 #include <map>
 #include <memory>
 #include <cstdio>
@@ -33,11 +34,11 @@ void samtoramntuple(const char *datafile,
    TStopwatch stopwatch;
    stopwatch.Start();
 
-   auto rootFile = std::unique_ptr<TFile>(TFile::Open(treefile, "RECREATE"));
-   if (!rootFile || !rootFile->IsOpen()) {
-      printf("Failed to create RAM file %s\n", treefile);
-      return;
-   }
+    auto rootFile = std::unique_ptr<TFile>(TFile::Open(treefile, "RECREATE"));
+    if (!rootFile || !rootFile->IsOpen()) {
+        std::cerr << "Failed to create RAM file " << treefile << std::endl;
+        return;
+    }
 
     RAMNTupleRecord::InitializeRefs();
 
@@ -300,3 +301,4 @@ void samtoramntuple_split_by_chromosome(const char *datafile, const char *output
       }
    }
 }
+

test/ramcoretests.cxx

@@ -9,7 +9,7 @@
 #include <cstdio>
 #include <cstdlib>
 #include <filesystem>
-#include <regex>
+
 #include "../tools/ramview.cxx"
 
 class ramcoreTest : public ::testing::Test {
@@ -55,14 +55,15 @@ TEST_F(ramcoreTest, ConversionProducesEqualEntries) {
     const char *region = "chrM:1-100000000";
 
     testing::internal::CaptureStdout();
-    ramview(ttreeFile, region, true, false, nullptr);
+    ramview(ttreeFile, region, /*cache=*/true, /*perfstats=*/false, nullptr);
     std::string ramview_output = testing::internal::GetCapturedStdout();
 
     testing::internal::CaptureStdout();
-    ramntupleview(rntupleFile, region, true, false, nullptr);
+    ramntupleview(rntupleFile, region, /*cache=*/true, /*perfstats=*/false, nullptr);
     std::string ramntupleview_output = testing::internal::GetCapturedStdout();
 
     EXPECT_TRUE(ramview_output.find("Found") != std::string::npos);
     EXPECT_TRUE(ramntupleview_output.find("Found") != std::string::npos);
     EXPECT_TRUE(ramntupleview_output.find("records in region") != std::string::npos);
 }
+

tools/ramview.cxx

@@ -66,7 +66,7 @@ Long64_t ramview(const char *file, const char *query, bool cache = true, bool pe
    auto end_entry = RAMRecord::GetIndex()->GetRow(refid, re0);
 
    printf("ramview: %s:%d (%lld) - %d (%lld)\n", rname.Data(), range_start, start_entry,
-                                                 range_end, end_entry);
+                                                range_end, end_entry);
 
    if (b->GetSplitLevel() > 0)
       t->SetBranchStatus("RAMRecord.*", 0);
@@ -119,7 +119,8 @@ Long64_t ramview(const char *file, const char *query, bool cache = true, bool pe
 
    std::string region_str =
       std::string(rname.Data()) + ":" + std::to_string(range_start) + "-" + std::to_string(range_end);
-   printf("Found %lld records in region %s\n", static_cast<long long>(count), region_str.c_str());
+   std::cout << "Found " << static_cast<long long>(count) << " records in region "
+             << region_str << std::endl;
 
    if (perfstats) {
       ps->SaveAs(perfstatsfilename);