Skip to content
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Commit 2b3cc99

Browse files
authored
Loosen up strict typings (#1)
* default value for fixVersions * cast to null * make version nullable * set globalId to empty string, because not every assigned link has a global id. just the links assigned from the api will have that field filled.
1 parent 2bc1b15 commit 2b3cc99

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/Issue/IssueField.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ class IssueField implements \JsonSerializable
5050

5151
public ?object $resolution;
5252

53-
public array $fixVersions;
53+
public ?array $fixVersions = null;
5454

5555
public ?Reporter $creator;
5656

@@ -60,8 +60,8 @@ class IssueField implements \JsonSerializable
6060

6161
public ?Reporter $assignee = null;
6262

63-
/** @var \JiraCloud\Issue\Version[] */
64-
public $versions;
63+
/** @var \JiraCloud\Issue\Version[]|null */
64+
public ?array $versions = null;
6565

6666
/** @var \JiraCloud\Issue\Attachment[] */
6767
public $attachment;

src/Issue/RemoteIssueLink.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ public function jsonSerialize()
2525
public function __construct()
2626
{
2727
$this->object = new RemoteObject();
28+
$this->globalId = '';
2829
}
2930

3031
public function setUrl(string $url): static

0 commit comments

Comments
 (0)