refactor: extract _format_summary from ConsoleEmitter for testability

The run summary formatting logic (counter arithmetic, category filtering,
pluralization) was embedded inside the _on_run_stopped rendering method.
Extracted it into a pure _format_summary function that can be unit-tested
without Rich, and added direct tests for all summary variants.

Co-authored-by: Ralphify <noreply@ralphify.co>

Author: 2 people

src/ralphify/_console_emitter.py

@@ -46,6 +46,24 @@ def _plural(count: int, word: str) -> str:
     return f"{count} {word}{'s' if count != 1 else ''}"
 
 
+def _format_summary(
+    total: int, completed: int, failed: int, timed_out_count: int
+) -> str:
+    """Build a plain-text run summary string from iteration counters.
+
+    ``timed_out_count`` is a subset of ``failed`` — non-timeout failures
+    and timeouts are shown as separate categories for clarity.
+    """
+    non_timeout_failures = failed - timed_out_count
+    parts = [f"{completed} succeeded"]
+    if non_timeout_failures:
+        parts.append(f"{non_timeout_failures} failed")
+    if timed_out_count:
+        parts.append(f"{timed_out_count} timed out")
+    detail = ", ".join(parts)
+    return f"{_plural(total, 'iteration')} {_ICON_DASH} {detail}"
+
+
 class _IterationSpinner:
     """Rich renderable that shows a spinner with elapsed time."""
 
@@ -164,21 +182,8 @@ def _on_run_stopped(self, data: RunStoppedData) -> None:
         if data["reason"] != STOP_COMPLETED:
             return
 
-        total = data["total"]
-        completed = data["completed"]
-        failed = data["failed"]
-        timed_out_count = data["timed_out_count"]
-
-        # timed_out_count is a subset of failed — show non-timeout failures
-        # and timeouts as separate categories for clarity.
-        non_timeout_failures = failed - timed_out_count
-        parts = [f"{completed} succeeded"]
-        if non_timeout_failures:
-            parts.append(f"{non_timeout_failures} failed")
-        if timed_out_count:
-            parts.append(f"{timed_out_count} timed out")
-        detail = ", ".join(parts)
-        self._console.print(f"\n[bold {_brand.BLUE}]──────────────────────[/]")
-        self._console.print(
-            f"[bold {_brand.GREEN}]Done:[/] {_plural(total, 'iteration')} {_ICON_DASH} {detail}"
+        summary = _format_summary(
+            data["total"], data["completed"], data["failed"], data["timed_out_count"]
         )
+        self._console.print(f"\n[bold {_brand.BLUE}]──────────────────────[/]")
+        self._console.print(f"[bold {_brand.GREEN}]Done:[/] {summary}")

tests/test_console_emitter.py

@@ -3,7 +3,7 @@
 import pytest
 from rich.console import Console
 
-from ralphify._console_emitter import ConsoleEmitter, _IterationSpinner
+from ralphify._console_emitter import ConsoleEmitter, _IterationSpinner, _format_summary
 from ralphify._events import Event, EventType
 
 
@@ -473,6 +473,38 @@ def test_completed_plural_iterations(self):
         assert "3 iterations" in output
 
 
+class TestFormatSummary:
+    def test_all_succeeded(self):
+        assert _format_summary(3, 3, 0, 0) == "3 iterations — 3 succeeded"
+
+    def test_singular_iteration(self):
+        assert _format_summary(1, 1, 0, 0) == "1 iteration — 1 succeeded"
+
+    def test_with_failures(self):
+        result = _format_summary(5, 4, 1, 0)
+        assert "4 succeeded" in result
+        assert "1 failed" in result
+        assert "timed out" not in result
+
+    def test_with_timeouts_only(self):
+        result = _format_summary(3, 2, 1, 1)
+        assert "2 succeeded" in result
+        assert "1 timed out" in result
+        # timed_out_count is subset of failed — no separate "failed" category
+        assert "failed" not in result
+
+    def test_with_mixed_failures_and_timeouts(self):
+        result = _format_summary(5, 3, 2, 1)
+        assert "3 succeeded" in result
+        assert "1 failed" in result
+        assert "1 timed out" in result
+
+    def test_all_failed(self):
+        result = _format_summary(3, 0, 3, 0)
+        assert "0 succeeded" in result
+        assert "3 failed" in result
+
+
 class TestIterationSpinner:
     def test_renders_elapsed_time(self):
         spinner = _IterationSpinner()