Skip to content

Commit 95534ce

Browse files
Fix SQL for saving boolean values
Note that the changes in Callbacks.php didn't solve the problem and may not be necessary, but should be fine anyway.
1 parent 021467d commit 95534ce

File tree

2 files changed

+7
-49
lines changed

2 files changed

+7
-49
lines changed

QuickBooks/Callbacks/SQL/Callbacks.php

Lines changed: 4 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -3820,20 +3820,9 @@ protected static function _AddRequest($type, $Object, $requestID, $user, $action
38203820

38213821
break;
38223822
case 'BOOLTYPE':
3823-
3824-
if ($value == 1)
3825-
{
3826-
$value = 'true';
3827-
}
3828-
else if ($value == 0)
3829-
{
3830-
$value = 'false';
3831-
}
3832-
else
3833-
{
3823+
if ($value != 0 && $value != 1) {
38343824
$use_in_request = false;
38353825
}
3836-
38373826
break;
38383827
default:
38393828
break;
@@ -3914,20 +3903,9 @@ protected static function _AddRequest($type, $Object, $requestID, $user, $action
39143903

39153904
break;
39163905
case 'BOOLTYPE':
3917-
3918-
if ($value == 1)
3919-
{
3920-
$value = 'true';
3921-
}
3922-
else if ($value == 0)
3923-
{
3924-
$value = 'false';
3925-
}
3926-
else
3927-
{
3906+
if ($value != 0 && $value != 1) {
39283907
$use_in_request = false;
39293908
}
3930-
39313909
break;
39323910
default:
39333911
break;
@@ -4209,20 +4187,9 @@ protected static function _ChildObjectsToXML($type, $action, $children, $parentP
42094187

42104188
break;
42114189
case 'BOOLTYPE':
4212-
4213-
if ($value == 1)
4214-
{
4215-
$value = 'true';
4216-
}
4217-
else if ($value == 0)
4218-
{
4219-
$value = 'false';
4220-
}
4221-
else
4222-
{
4190+
if ($value != 0 && $value != 1) {
42234191
$use_in_request = false;
42244192
}
4225-
42264193
break;
42274194
default:
42284195
break;
@@ -4260,20 +4227,9 @@ protected static function _ChildObjectsToXML($type, $action, $children, $parentP
42604227

42614228
break;
42624229
case 'BOOLTYPE':
4263-
4264-
if ($value == 1)
4265-
{
4266-
$value = 'true';
4267-
}
4268-
else if ($value == 0)
4269-
{
4270-
$value = 'false';
4271-
}
4272-
else
4273-
{
4230+
if ($value != 0 && $value != 1) {
42744231
$use_in_request = false;
42754232
}
4276-
42774233
break;
42784234
default:
42794235
break;

QuickBooks/Driver/Sql.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3714,7 +3714,9 @@ public function insert($table, $object, $discov_and_resync = true)
37143714
*/
37153715
protected function fmtValue($field,$value) {
37163716
if (is_null($value)) $sql = 'NULL';
3717-
elseif (is_numeric($value)) {
3717+
elseif (is_numeric($value) ||
3718+
(!strncmp($field,'Is',2) && ($value == 'true' || $value == 'false')))
3719+
{
37183720
$sql = $value;
37193721
}
37203722
elseif (!strncmp($field,'Time',4)) {

0 commit comments

Comments
 (0)