Skip to content

Conversation

@emhgit
Copy link
Contributor

@emhgit emhgit commented Nov 17, 2025

Place an "x" in the corresponding checkbox if it is done or does not apply to this pull request.

  • I have tested my code.
  • I have added my solution according to the steps here.
  • I have followed the code conventions mentioned here.
    • I understand that if it is clear that I have not attempted to follow these conventions, my PR will be closed.
    • If changes are requested, I will re-request a review after addressing them.
  • I have linked this PR to any issues that it closes.

I removed the errors that were thrown and just put "Unknown" as placeholders for values that could not be determined. This should allow for manual editing

Copy link
Member

@ryanchou-dev ryanchou-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! i think it'd also be good to have a small error message letting them know that the parsing failed (and that they can edit the unknown fields after pasting).

Copy link
Member

@Sosuke23 Sosuke23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works perfectly fine.

@emhgit
Copy link
Contributor Author

emhgit commented Nov 17, 2025

awesome! i think it'd also be good to have a small error message letting them know that the parsing failed (and that they can edit the unknown fields after pasting).

that’s a good idea

@stale
Copy link

stale bot commented Nov 25, 2025

This pull request has been automatically marked as stale because it has not had recent activity. Please address the requested changes and re-request reviews. Thank you for your contribution!

@stale stale bot added the stale label Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants