fix: enhance username detection tests with time constraints and error handling

Author: Ali-Sdg90

__tests__/handlers/messages.test.js

@@ -206,7 +206,22 @@ describe("messages handler", () => {
         await handler(ctx, jest.fn());
     });
 
-    test("detects and registers valid username", async () => {
+    test("detects and registers valid username during allowed time", async () => {
+        // Mock Date to be Sunday at 17:45 Tehran time
+        const mockDate = new Date("2025-10-26T14:15:00Z"); // 17:45 Tehran time
+        const realDate = global.Date;
+        global.Date = class extends Date {
+            constructor(...args) {
+                if (args.length === 0) {
+                    return mockDate;
+                }
+                return new realDate(...args);
+            }
+            static now() {
+                return mockDate.getTime();
+            }
+        };
+
         // Ensure deterministic behavior by mocking config and spamProtection
         jest.doMock("../../bot/config/config", () => ({
             ADMIN_GROUP_ID: 999,
@@ -233,6 +248,9 @@ describe("messages handler", () => {
 
         expect(ctx.reply).toHaveBeenCalled();
         expect(ctx.telegram.sendMessage).toHaveBeenCalled();
+
+        // Restore original Date
+        global.Date = realDate;
     });
 
     test("messages handler returns early on pinned_message present", async () => {
@@ -282,7 +300,22 @@ describe("messages handler", () => {
         expect(handler(ctx)).resolves.toBeUndefined();
     });
 
-    test("private valid username registers and sends admin message", async () => {
+    test("private valid username registers and sends admin message during allowed time", async () => {
+        // Mock Date to be Sunday at 17:45 Tehran time
+        const mockDate = new Date("2025-10-26T14:15:00Z"); // 17:45 Tehran time
+        const realDate = global.Date;
+        global.Date = class extends Date {
+            constructor(...args) {
+                if (args.length === 0) {
+                    return mockDate;
+                }
+                return new realDate(...args);
+            }
+            static now() {
+                return mockDate.getTime();
+            }
+        };
+
         jest.mock("../../bot/config/config", () => ({
             ADMIN_GROUP_ID: 999,
             blockedUsers: new Set(),
@@ -309,6 +342,9 @@ describe("messages handler", () => {
             "✅ یوزرنیم شما با موفقیت ثبت شد."
         );
         expect(ctx.telegram.sendMessage).toHaveBeenCalled();
+
+        // Restore original Date
+        global.Date = realDate;
     });
 
     test("private non-text logs and still not crash", async () => {

__tests__/utils/scheduleMessage.test.js

@@ -12,7 +12,8 @@ describe("scheduleAdminMessage util", () => {
     test("schedules a job and handles no event", () => {
         // Mock node-cron
         jest.mock("node-cron", () => ({
-            schedule: (expr, fn) => {
+            schedule: (expr, fn, options) => {
+                expect(options).toEqual({ timezone: "Asia/Tehran" });
                 fn(); // call immediately for test
                 return { destroy: jest.fn() };
             },
@@ -26,15 +27,18 @@ describe("scheduleAdminMessage util", () => {
         // Mock config
         jest.mock("../../bot/config/config", () => ({ ADMIN_GROUP_ID: 123 }));
 
-        const { scheduleAdminMessage } = require("../../bot/utils/scheduleMessage");
+        const {
+            scheduleAdminMessage,
+        } = require("../../bot/utils/scheduleMessage");
 
         expect(() => scheduleAdminMessage(bot)).not.toThrow();
         expect(mockSendMessage).not.toHaveBeenCalled();
     });
 
-    test("when event exists, calls sendMessage", () => {
+    test("when event exists, calls sendMessage with correct formatting", () => {
         jest.mock("node-cron", () => ({
-            schedule: (expr, fn) => {
+            schedule: (expr, fn, options) => {
+                expect(options).toEqual({ timezone: "Asia/Tehran" });
                 fn();
                 return { destroy: jest.fn() };
             },
@@ -46,20 +50,74 @@ describe("scheduleAdminMessage util", () => {
 
         jest.mock("../../bot/config/config", () => ({ ADMIN_GROUP_ID: 123 }));
 
-        const { scheduleAdminMessage } = require("../../bot/utils/scheduleMessage");
+        const {
+            scheduleAdminMessage,
+        } = require("../../bot/utils/scheduleMessage");
 
         scheduleAdminMessage(bot);
 
         expect(mockSendMessage).toHaveBeenCalledWith(
             123,
             expect.stringContaining("TestTitle"),
+            expect.objectContaining({ parse_mode: "MarkdownV2" })
+        );
+    });
+
+    test("handles initial sendMessage error and sends error notification", async () => {
+        const errorMessage = "sendMessage failed";
+        const firstSendError = new Error(errorMessage);
+        let sendMessageCallCount = 0;
+
+        jest.mock("node-cron", () => ({
+            schedule: (expr, fn, options) => {
+                expect(options).toEqual({ timezone: "Asia/Tehran" });
+                return fn(); // call immediately
+            },
+        }));
+
+        jest.mock("../../bot/utils/getTodayEvent", () => ({
+            getTodayEvent: () => ({ hasEvent: true, title: "TestTitle" }),
+        }));
+
+        jest.mock("../../bot/config/config", () => ({ ADMIN_GROUP_ID: 123 }));
+
+        // Mock bot that fails first message but succeeds error notification
+        const botWithRecoverableError = {
+            telegram: {
+                sendMessage: jest.fn(() => {
+                    sendMessageCallCount++;
+                    if (sendMessageCallCount === 1) {
+                        throw firstSendError;
+                    }
+                    return Promise.resolve();
+                }),
+            },
+        };
+
+        const {
+            scheduleAdminMessage,
+        } = require("../../bot/utils/scheduleMessage");
+
+        expect(() =>
+            scheduleAdminMessage(botWithRecoverableError)
+        ).not.toThrow();
+
+        expect(
+            botWithRecoverableError.telegram.sendMessage
+        ).toHaveBeenCalledTimes(2);
+        expect(
+            botWithRecoverableError.telegram.sendMessage
+        ).toHaveBeenLastCalledWith(
+            123,
+            expect.stringContaining(errorMessage),
             expect.objectContaining({ parse_mode: "Markdown" })
         );
     });
 
-    test("handles sendMessage error gracefully", async () => {
+    test("handles both initial and error notification failures", async () => {
         jest.mock("node-cron", () => ({
-            schedule: (expr, fn) => {
+            schedule: (expr, fn, options) => {
+                expect(options).toEqual({ timezone: "Asia/Tehran" });
                 return fn(); // call immediately
             },
         }));
@@ -70,17 +128,20 @@ describe("scheduleAdminMessage util", () => {
 
         jest.mock("../../bot/config/config", () => ({ ADMIN_GROUP_ID: 123 }));
 
-        // Mock bot.telegram.sendMessage to throw error
-        const botWithError = {
+        // Mock bot where both messages fail
+        const botWithTotalError = {
             telegram: {
                 sendMessage: jest.fn(() => {
-                    throw new Error("sendMessage failed");
+                    throw new Error("Complete failure");
                 }),
             },
         };
 
-        const { scheduleAdminMessage } = require("../../bot/utils/scheduleMessage");
+        const {
+            scheduleAdminMessage,
+        } = require("../../bot/utils/scheduleMessage");
 
-        expect(() => scheduleAdminMessage(botWithError)).not.toThrow();
+        expect(() => scheduleAdminMessage(botWithTotalError)).not.toThrow();
+        expect(botWithTotalError.telegram.sendMessage).toHaveBeenCalledTimes(2);
     });
 });