perf tracking in yaml compiler

Author: KSDaemon

packages/cubejs-schema-compiler/src/compiler/YamlCompiler.ts

@@ -16,6 +16,7 @@ import { nonStringFields } from './CubeValidator';
 import { CubeDictionary } from './CubeDictionary';
 import { ErrorReporter } from './ErrorReporter';
 import { camelizeCube } from './utils';
+import { perfTracker } from './PerfTracker';
 
 type EscapeStateStack = {
   inFormattedStr?: boolean;
@@ -24,6 +25,8 @@ type EscapeStateStack = {
   depth?: number;
 };
 
+const PY_TEMPLATE_SYNTAX = /\{.*}/ms;
+
 export class YamlCompiler {
   public dataSchemaCompiler: DataSchemaCompiler | null = null;
 
@@ -90,7 +93,9 @@ export class YamlCompiler {
     for (const key of Object.keys(yamlObj)) {
       if (key === 'cubes') {
         (yamlObj.cubes || []).forEach(({ name, ...cube }) => {
+          const transpileAndPrepareJsFileTimer = perfTracker.start('yaml-transpileAndPrepareJsFile');
           const transpiledFile = this.transpileAndPrepareJsFile(file, 'cube', { name, ...cube }, errorsReport);
+          transpileAndPrepareJsFileTimer.end();
           this.dataSchemaCompiler?.compileJsFile(transpiledFile, errorsReport);
         });
       } else if (key === 'views') {
@@ -132,7 +137,10 @@ export class YamlCompiler {
 
     cubeObj.hierarchies = this.yamlArrayToObj(cubeObj.hierarchies || [], 'hierarchies', errorsReport);
 
-    return this.transpileYaml(cubeObj, [], cubeObj.name, errorsReport);
+    const transpileYamlTimer = perfTracker.start('transpileYaml');
+    const res = this.transpileYaml(cubeObj, [], cubeObj.name, errorsReport);
+    transpileYamlTimer.end();
+    return res;
   }
 
   private transpileYaml(obj, propertyPath, cubeName, errorsReport: ErrorReporter) {
@@ -146,11 +154,17 @@ export class YamlCompiler {
             return this.parsePythonIntoArrowFunction(obj, cubeName, obj, errorsReport);
           } else if (Array.isArray(obj)) {
             const resultAst = t.program([t.expressionStatement(t.arrayExpression(obj.map(code => {
-              let ast: t.Program | t.NullLiteral | t.BooleanLiteral | t.NumericLiteral | null = null;
+              let ast: t.Program | t.NullLiteral | t.BooleanLiteral | t.NumericLiteral | t.StringLiteral | null = null;
               // Special case for accessPolicy.rowLevel.filter.values and other values-like fields
               if (propertyPath[propertyPath.length - 1] === 'values') {
                 if (typeof code === 'string') {
-                  ast = this.parsePythonAndTranspileToJs(`f"${this.escapeDoubleQuotes(code)}"`, errorsReport);
+                  if (code.match(PY_TEMPLATE_SYNTAX)) {
+                    const parsePythonAndTranspileToJsTimer184 = perfTracker.start('parsePythonAndTranspileToJs call 184');
+                    ast = this.parsePythonAndTranspileToJs(`f"${this.escapeDoubleQuotes(code)}"`, errorsReport);
+                    parsePythonAndTranspileToJsTimer184.end();
+                  } else {
+                    ast = t.stringLiteral(code);
+                  }
                 } else if (typeof code === 'boolean') {
                   ast = t.booleanLiteral(code);
                 } else if (typeof code === 'number') {
@@ -162,7 +176,9 @@ export class YamlCompiler {
                 }
               }
               if (ast === null) {
+                const parsePythonAndTranspileToJsTimer201 = perfTracker.start('parsePythonAndTranspileToJs call 201');
                 ast = this.parsePythonAndTranspileToJs(code, errorsReport);
+                parsePythonAndTranspileToJsTimer201.end();
               }
               return this.extractProgramBodyIfNeeded(ast);
             }).filter(ast => !!ast)))]);
@@ -173,7 +189,9 @@ export class YamlCompiler {
     }
 
     if (propertyPath[propertyPath.length - 1] === 'extends') {
+      const parsePythonAndTranspileToJsTimer214 = perfTracker.start('parsePythonAndTranspileToJs call 214');
       const ast = this.parsePythonAndTranspileToJs(obj, errorsReport);
+      parsePythonAndTranspileToJsTimer214.end();
       return this.astIntoArrowFunction(ast, obj, cubeName, name => this.cubeDictionary.resolveCube(name));
     } else if (typeof obj === 'string') {
       let code = obj;
@@ -182,7 +200,9 @@ export class YamlCompiler {
         code = `f"${this.escapeDoubleQuotes(obj)}"`;
       }
 
+      const parsePythonAndTranspileToJsTimer225 = perfTracker.start('parsePythonAndTranspileToJs call 225');
       const ast = this.parsePythonAndTranspileToJs(code, errorsReport);
+      parsePythonAndTranspileToJsTimer225.end();
       return this.extractProgramBodyIfNeeded(ast);
     } else if (typeof obj === 'boolean') {
       return t.booleanLiteral(obj);
@@ -260,7 +280,9 @@ export class YamlCompiler {
   }
 
   private parsePythonIntoArrowFunction(codeString: string, cubeName, originalObj, errorsReport: ErrorReporter) {
+    const parsePythonAndTranspileToJsTimer301 = perfTracker.start('parsePythonAndTranspileToJs call 301');
     const ast = this.parsePythonAndTranspileToJs(codeString, errorsReport);
+    parsePythonAndTranspileToJsTimer301.end();
     return this.astIntoArrowFunction(ast as any, codeString, cubeName);
   }
 
@@ -270,8 +292,12 @@ export class YamlCompiler {
     }
 
     try {
+      const parsePythonAndTranspileToJsTimer = perfTracker.start('PythonParser->transpileToJs()');
+
       const pythonParser = new PythonParser(codeString);
-      return pythonParser.transpileToJs();
+      const res = pythonParser.transpileToJs();
+      parsePythonAndTranspileToJsTimer.end();
+      return res;
     } catch (e: any) {
       errorsReport.error(`Can't parse python expression. Most likely this type of syntax isn't supported yet: ${e.message || e}`);
     }
@@ -280,6 +306,7 @@ export class YamlCompiler {
   }
 
   private astIntoArrowFunction(input: t.Program | t.NullLiteral, codeString: string, cubeName, resolveSymbol?: (string) => any) {
+    const astIntoArrowFunctionTimer = perfTracker.start('astIntoArrowFunction');
     const initialJs = babelGenerator(input, {}, codeString).code;
 
     // Re-parse generated JS to set all necessary parent paths
@@ -304,6 +331,7 @@ export class YamlCompiler {
     babelTraverse(ast, traverseObj);
 
     const body: any = ast.program.body[0];
+    astIntoArrowFunctionTimer.end();
     return body?.expression;
   }