Skip to content

Align TableColumn Type with Annotation (Client Core) #9976

@joealden

Description

@joealden

Is your feature request related to a problem? Please describe.

We have two related types (as I believe table columns are derived from the annotation data):

export type Annotation = {
title: string;
shortTitle: string;
type: string;
meta?: any;
format?: 'currency' | 'percent' | 'number';
drillMembers?: any[];
drillMembersGrouped?: any;
granularity?: GranularityAnnotation;
};

export type TableColumn = {
key: string;
dataIndex: string;
meta?: any;
type: string | number;
title: string;
shortTitle: string;
format?: any;
children?: TableColumn[];
};

I'm wondering why the types for type and format are different? I feel like Annotation is the correct one?

Describe the solution you'd like

Update the TableColumn type to better match Annotation.

Describe alternatives you've considered

N/A

Additional context

N/A

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions