Skip to content

Commit 528e97f

Browse files
authored
Merge pull request #8 from curityio/bugfix/fix-error-message
Updated SDK version and fixed error message
2 parents 46caaf4 + 419d8f3 commit 528e97f

File tree

3 files changed

+11
-9
lines changed

3 files changed

+11
-9
lines changed

README.rst

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,18 +8,18 @@ GitHub Authenticator Plug-in
88
:target: https://curity.io/resources/code-examples/status/
99

1010

11-
This project provides an opens source GitHub Authenticator plug-in for the Curity Identity Server. This allows an administrator to add functionality to Curity which will then enable end users to login using their GitHub credentials. The app that integrates with Curity may also be configured to receive the GitHub access token, allowing it to manage resources in a GitHub.
11+
This project provides an opens source GitHub Authenticator plug-in for the Curity Identity Server. This allows an administrator to add functionality to the Curity Identity Server which will then enable end users to login using their GitHub credentials. The app that integrates with the Curity Identity Server may also be configured to receive the GitHub access token, allowing it to manage resources in a GitHub.
1212

1313
System Requirements
1414
~~~~~~~~~~~~~~~~~~~
1515

16-
* Curity Identity Server 2.4.0 and `its system requirements <https://developer.curity.io/docs/latest/system-admin-guide/system-requirements.html>`_
16+
* Curity Identity Server 7.1.0 and `its system requirements <https://developer.curity.io/docs/latest/system-admin-guide/system-requirements.html>`_
1717

1818
Requirements for Building from Source
1919
"""""""""""""""""""""""""""""""""""""
2020

2121
* Maven 3
22-
* Java JDK v. 8
22+
* Java SDK 17 or later
2323

2424
Compiling the Plug-in from Source
2525
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

pom.xml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
<groupId>io.curity.identityserver.plugin</groupId>
88
<artifactId>identityserver.plugins.authenticators.github</artifactId>
9-
<version>1.4.0</version>
9+
<version>1.5.0</version>
1010

1111
<name>GitHub Authenticator</name>
1212

@@ -21,8 +21,8 @@
2121
<artifactId>maven-compiler-plugin</artifactId>
2222
<version>3.1</version>
2323
<configuration>
24-
<source>1.8</source>
25-
<target>1.8</target>
24+
<source>17</source>
25+
<target>17</target>
2626
</configuration>
2727
</plugin>
2828
</plugins>
@@ -32,12 +32,14 @@
3232
<dependency>
3333
<groupId>se.curity.identityserver</groupId>
3434
<artifactId>identityserver.sdk</artifactId>
35-
<version>5.2.0</version>
35+
<version>7.1.0</version>
36+
<scope>provided</scope>
3637
</dependency>
3738
<dependency>
3839
<groupId>org.slf4j</groupId>
3940
<artifactId>slf4j-api</artifactId>
40-
<version>1.7.25</version>
41+
<version>1.7.36</version>
42+
<scope>provided</scope>
4143
</dependency>
4244
</dependencies>
4345

src/main/java/io/curity/identityserver/plugin/github/authentication/CallbackRequestHandler.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,7 @@ private void handleError(CallbackGetRequestModel requestModel)
275275
_logger.warn("Got an error from StackExchange: {} - {}", requestModel.getError(),
276276
requestModel.getErrorDescription());
277277

278-
throw _exceptionFactory.externalServiceException("Login with StackExchange failed");
278+
throw _exceptionFactory.externalServiceException("Login with GitHub failed");
279279
}
280280
}
281281

0 commit comments

Comments
 (0)