Skip to content

Commit c1984d9

Browse files
committed
curl: re-enable UNICODE by default
The article https://blog.orange.tw/posts/2025-01-worstfit-unveiling-hidden-transformers-in-windows-ansi/ may tip the balance towards UNICODE enabled being the less bad solution. It mitigates Windows's own shortcomings in translating between Unicode and 8-bit codepages (aptly coined "WorstFit"). It may also be a way to receive more feedback on curl UNICODE mode issues, also possibly giving a new momentum to address them. Original reasons for disabling, written in bb02905 still apply today. Also add a `nounicode` config option to build without UNICODE. Follow-up to bb02905
1 parent cb28386 commit c1984d9

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ SSL | ✓ | ✓ | ✓ | ✓ | ✓ | ✓
9595
SSPI | ✓ | - | - | ✓¹ | ✓¹ | ✓¹ | ✓¹ | |
9696
SSLS-EXPORT | ✓ | ✓ | ✓ | ✓ | | | | |
9797
threadsafe | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ |
98-
Unicode | | - | - | | | | | |
98+
Unicode | | - | - | ✓¹ | ✓¹ | ✓¹ | ✓¹ | ✓¹ |
9999
UnixSockets | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | |
100100
zstd | ✓ | ✓ | ✓ | ✓ | | | | |
101101

_build.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ set -o xtrace -o errexit -o nounset; [ -n "${BASH:-}${ZSH_NAME:-}" ] && set -o p
7575
# curldocs include curl Markdown manual pages in the package
7676
# msvcrt build against msvcrt instead of UCRT (for win target)
7777
# gcc build with GCC (including Apple clang aliased to gcc) (defaults to llvm, and "gcc" (= Apple clang) for mac target)
78-
# unicode build curl in UNICODE mode (for win target) [EXPERIMENTAL]
78+
# nounicode build curl without [EXPERIMENTAL] UNICODE mode (for win target)
7979
# osnoidn build curl without OS-supplied IDN support
8080
# werror turn compiler warnings into errors
8181
# nodumpconf do not dump curl_config.h

curl.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ _VER="$1"
4444
# [ "${_CC}" = 'gcc' ] && LDFLAGS+=' -Wl,--trace'
4545
fi
4646

47-
if [ "${_OS}" = 'win' ] && [[ "${_CONFIG}" = *'unicode'* ]]; then
47+
if [ "${_OS}" = 'win' ] && [[ "${_CONFIG}" != *'nounicode'* ]]; then
4848
options+=' -DENABLE_UNICODE=ON'
4949
fi
5050

0 commit comments

Comments
 (0)