Skip to content

Commit d887d63

Browse files
committed
enable c-ares by default in curl 8.12.0 for HTTPS RR support [ci skip]
Replace `noh3` alternative build example with `nocares`. Size increase is about 200 KiB for the distro `.zip` and `.tar.gz` files, and about the same amount for `curl.exe` and `libcurl*.dll`. c-ares static lib is 440 KiB in size (on Windows). This is not small, but fine. The bigger issue is that c-ares needs patching to build correctly and it's also unclear if it breaks the binary on supported systems back to Windows Vista. [EXPERIMENTAL] disable c-ares due to extremely slow builds
1 parent b166381 commit d887d63

File tree

3 files changed

+14
-5
lines changed

3 files changed

+14
-5
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ feature | Windows | Linux | macOS | noh3 | mini | micro | nano
8181
--------------| --------| --------| --------| --------| --------| --------| --------| --------|
8282
alt-svc | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | | |
8383
AppleSecTrust | - | - | ✓ | ✓¹ | ✓¹ | ✓¹ | ✓¹ | ✓¹ |
84-
asyn-rr | | | | | | | | |
84+
asyn-rr | | ✓ | ✓ | | | | | |
8585
AsynchDNS | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ |
8686
brotli | ✓ | ✓ | ✓ | ✓ | | | | |
8787
CAcert | ✓ | ✓ | | ✓¹ | ✓¹ | ✓¹ | ✓¹ | ✓¹ |
@@ -90,7 +90,7 @@ HSTS | ✓ | ✓ | ✓ | ✓ | ✓ | ✓
9090
HTTP2 | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | | |
9191
HTTP3 | ✓ | ✓ | ✓ | | | | | |
9292
HTTPS-proxy | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ |
93-
HTTPSRR | | | | | | | | |
93+
HTTPSRR | | ✓ | ✓ | | | | | |
9494
IDN | ✓ | | ✓ | ✓¹ | ✓¹ | ✓¹ | ✓¹ | |
9595
IPv6 | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ |
9696
Kerberos | ✓ | | | ✓¹ | ✓¹ | ✓¹ | ✓¹ | |

_build.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ set -o xtrace -o errexit -o nounset; [ -n "${BASH:-}${ZSH_NAME:-}" ] && set -o p
4242
# nozstd build without zstd
4343
# nozlib build without zlib
4444
# zlibold build with zlib (classic) instead of zlib-ng
45+
# nocares build without c-ares
4546
# noftp build without FTP/FTPS support
4647
# nohttp build without HTTP and proxy support
4748
# nocookie build without cookie support

_dl.sh

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -732,9 +732,17 @@ if [[ ! "${_CONFIG}" =~ (zero|bldtst|pico|nano|micro|mini) ]]; then
732732
fi
733733
fi
734734

735-
if [[ "${_CONFIG}" = *'cares'* ]]; then
736-
_DEPS+=' cares'
737-
fi
735+
#if [[ "${_CONFIG}" = *'dev'* ]]; then
736+
# if [[ ! "${_CONFIG}" =~ (zero|bldtst|pico|nano|micro|mini) || "${_CONFIG}" = *'cares'* ]]; then
737+
# if [[ "${_CONFIG}" != *'nocares'* ]]; then
738+
# _DEPS+=' cares'
739+
# fi
740+
# fi
741+
#else
742+
# if [[ "${_CONFIG}" = *'cares'* ]]; then
743+
# _DEPS+=' cares'
744+
# fi
745+
#fi
738746

739747
if [[ ! "${_CONFIG}" =~ (zero|bldtst|nocookie) ]]; then
740748
_DEPS+=' psl'

0 commit comments

Comments
 (0)