-
Notifications
You must be signed in to change notification settings - Fork 95
developer: add a configuration for turning lru_caching off #7077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f06144e to
4a068e1
Compare
ChrisPaulBennett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
I closed and reopened the PR to hopefully clear the macOS test that is failing |
|
Tests happy. Coverage complaining about pre-existing coverage holes. |
|
|
||
|
|
||
| # NOTE: We cache some datetime cycling operations to improve compute | ||
| # perforance. For profiling, this can be disabled by setting the environment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # perforance. For profiling, this can be disabled by setting the environment | |
| # performance. For profiling, this can be disabled by setting the environment |
|
It's fine as far as it goes. Do you want to consider these other cases (there aren't many): |
wxtim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
I went with "no" on those:
|
In order to perform memory profiling for Cylc it is generally necessary to disable the
lru_cachemechanism that we use to speedup datetime / recurrence operations.Let's make this configurable via an environment variable rather than performing this hack every time.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.