perf: skip :visible filter count when log:false #32948
Open
+20
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
perf/skip-visible-check-log-false
|
| Run status |
|
| Run duration | 19m 00s |
| Commit |
|
| Committer | Cacie Prins |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
10
|
Pending
|
1098
|
Skipped
|
4
|
Passing
|
26598
|
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
45.61%
|
|
|---|---|
|
Untested elements
|
187
|
|
Tested elements
|
161
|
Accessibility
97.98%
|
|
|---|---|
|
Failed rules
|
4 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
101
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
When
log:false, we don't need to determine whether any matched elements are visible. Because the log entry won't be visible.Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Skips
:visiblefiltering for hidden (log: false) command logs and makessetElAttrschainable, with tests and changelog updates.Log.setElAttrs()to skip:visiblefiltering whenhiddenis set, avoiding costly DOM checks.setElAttrsto return theLoginstance for chaining.packages/driver/cypress/e2e/cypress/log.cy.jsasserting no.filter(':visible')when log is hidden.cli/CHANGELOG.mdwith performance note about skipping visibility assessments for hidden command logs.Written by Cursor Bugbot for commit 94f4542. This will update automatically on new commits. Configure here.