chore: convert server files p3 #32950
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| contents, | ||
| } | ||
| }) | ||
| } |
There was a problem hiding this comment.
Bug: Unresolved Promises Break File Selection
The readFiles function returns an array of unresolved promises instead of awaiting them. The original code used Bluebird.map() which waits for all promises to resolve, but the new code uses Array.map() with an async callback, which immediately returns an array of promises. This breaks the selectFile command as callers expect resolved file data, not promises.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Migrates file IO and fixture handling to TypeScript, updates importing sites and fs typings, and converts/updates unit tests and snapshots.
packages/server/lib/files.js→files.tsandpackages/server/lib/fixture.js→fixture.tswith equivalent async APIs (readFile,readFiles,writeFile,get, etc.).xhrs.tsandsocket-base.tsusefixture.getasfixtureGet;privileged-commands-manager.tsimports* as files.fs.readJsonAsynctyping inlib/util/fs.ts; use it infiles.tsandutil/file.ts(remove ts-ignore usage).@ts-expect-errorwhere needed.packages/server/test/unit/files_spec.js→files_spec.ts; updatefixture_spec.tsto ESM/TS imports and context setup.__snapshots__/fixture_spec.ts.jsfor invalid JSON error.Written by Cursor Bugbot for commit 9ebb342. This will update automatically on new commits. Configure here.