Skip to content

Commit 65b07db

Browse files
committed
Update release notes
1 parent 236e452 commit 65b07db

File tree

5 files changed

+22
-13
lines changed

5 files changed

+22
-13
lines changed

RELEASE_NOTES.md

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,18 @@
55

66
This version increases the action sheet integrity by restricting what you can do
77
with it. This involves some breaking changes, but they should not affect you. If
8-
you think any new rule is bad, or affect you in a critical way, just let me know.
8+
you think any new rule is bad or affect you, please let me know.
99

10-
### ActionSheet:
10+
11+
### New Features
12+
13+
@sebbo176 has added support for subtitles in the various select items, which now
14+
also changes the cell style of an item if the subtitle is set. He has also added
15+
an unselected icon to the select items, which means that you can now have images
16+
for unselected items as well (e.g. an unchecked checkbox).
17+
18+
19+
### Breaking Changes - ActionSheet:
1120

1221
* The `items` and `buttons` properties are now `internal(set)`, which means that
1322
they can only be set with `init(...)` or with `setup(items:)`. This protects the

Sheeeeeeeeet/Appearance/Items/ActionSheetLinkItemAppearance.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ open class ActionSheetLinkItemAppearance: ActionSheetItemAppearance {
1919

2020
public override init(copy: ActionSheetItemAppearance) {
2121
super.init(copy: copy)
22-
guard let copy = copy as? ActionSheetLinkItemAppearance else { return }
23-
linkIcon = copy.linkIcon
22+
let copy = copy as? ActionSheetLinkItemAppearance
23+
linkIcon = copy?.linkIcon
2424
}
2525

2626

Sheeeeeeeeet/Appearance/Items/ActionSheetMultiSelectToggleItemAppearance.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ open class ActionSheetMultiSelectToggleItemAppearance: ActionSheetItemAppearance
1919

2020
public override init(copy: ActionSheetItemAppearance) {
2121
super.init(copy: copy)
22-
guard let copy = copy as? ActionSheetMultiSelectToggleItemAppearance else { return }
23-
deselectAllTextColor = copy.deselectAllTextColor
24-
selectAllTextColor = copy.selectAllTextColor
22+
let copy = copy as? ActionSheetMultiSelectToggleItemAppearance
23+
deselectAllTextColor = copy?.deselectAllTextColor
24+
selectAllTextColor = copy?.selectAllTextColor
2525
}
2626

2727

Sheeeeeeeeet/Appearance/Items/ActionSheetSelectItemAppearance.swift

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,11 @@ open class ActionSheetSelectItemAppearance: ActionSheetItemAppearance {
3434
super.init(copy: copy)
3535
selectedTextColor = copy.textColor
3636
selectedTintColor = copy.tintColor
37-
guard let copy = copy as? ActionSheetSelectItemAppearance else { return }
38-
selectedIcon = copy.selectedIcon
39-
selectedTextColor = copy.selectedTextColor ?? selectedTextColor
40-
selectedTintColor = copy.selectedTintColor ?? selectedTintColor
41-
selectedIconTintColor = copy.selectedIconTintColor ?? selectedTintColor
37+
let copy = copy as? ActionSheetSelectItemAppearance
38+
selectedIcon = copy?.selectedIcon
39+
selectedTextColor = copy?.selectedTextColor ?? selectedTextColor
40+
selectedTintColor = copy?.selectedTintColor ?? selectedTintColor
41+
selectedIconTintColor = copy?.selectedIconTintColor ?? selectedTintColor
4242
}
4343

4444

Sheeeeeeeeet/Extensions/UIView+Nib.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,6 @@ import UIKit
1111
extension UIView {
1212

1313
static var defaultNib: UINib {
14-
return UINib(nibName: className, bundle: Bundle(for: self))
14+
return UINib(nibName: className, bundle: self.bundle)
1515
}
1616
}

0 commit comments

Comments
 (0)