[current_results] Update dependencies and lints

- Update dependencies
- Adds dependencies used but missing from pubspec
- Switch to package:lints and make fixes

Change-Id: I6ccbf0bc57b6def2bb49760ecabedb1d51d217d6
Reviewed-on: https://dart-review.googlesource.com/c/dart_ci/+/351820
Reviewed-by: Alexander Thomas <[email protected]>
Reviewed-by: William Hesse <[email protected]>
Auto-Submit: Parker Lougheed <[email protected]>

Author: parlough

current_results/analysis_options.yaml

@@ -1,14 +1 @@
-# Defines a default set of lint rules enforced for
-# projects at Google. For details and rationale,
-# see https://github.com/dart-lang/pedantic#enabled-lints.
-include: package:pedantic/analysis_options.yaml
-
-# For lint rules and documentation, see http://dart-lang.github.io/linter/lints.
-# Uncomment to specify additional rules.
-# linter:
-#   rules:
-#     - camel_case_types
-
-analyzer:
-#   exclude:
-#     - path/to/excluded/files/**
+include: package:lints/recommended.yaml

current_results/bin/client.dart

@@ -22,7 +22,7 @@ void main(List<String> args) async {
   await runner.run(args);
 }
 
-abstract class gRpcCommand extends Command {
+abstract class GrpcCommand extends Command<void> {
   Future<void> runWithClient(QueryClient client);
   @override
   Future<void> run() async {
@@ -41,7 +41,7 @@ abstract class gRpcCommand extends Command {
   }
 }
 
-class QueryCommand extends gRpcCommand {
+class QueryCommand extends GrpcCommand {
   QueryCommand() {
     argParser.addOption('filter',
         abbr: 'f',
@@ -72,7 +72,7 @@ class QueryCommand extends gRpcCommand {
   }
 }
 
-class ListTestsCommand extends gRpcCommand {
+class ListTestsCommand extends GrpcCommand {
   ListTestsCommand() {
     argParser.addOption('prefix',
         defaultsTo: '', help: 'test name prefix to fetch test names for');
@@ -96,7 +96,7 @@ class ListTestsCommand extends gRpcCommand {
   }
 }
 
-class FetchCommand extends gRpcCommand {
+class FetchCommand extends GrpcCommand {
   @override
   String get name => 'fetch';
   @override

current_results/bin/server.dart

@@ -28,7 +28,9 @@ Future<void> startServer(int port, ResultsBucket bucket) async {
   final notifications = BucketNotifications();
   await notifications.initialize();
   final current = await loadData(bucket);
-  final grpcServer = Server([QueryService(current, notifications, bucket)]);
+  final grpcServer = Server.create(
+    services: [QueryService(current, notifications, bucket)],
+  );
   await grpcServer.serve(port: port);
   print('Grpc serving on port ${grpcServer.port}');
 }
@@ -48,6 +50,6 @@ Future<Slice> loadData(ResultsBucket bucket) async {
     } catch (e, stack) {
       print('Error loading configuration $configurationDirectory: $e\n$stack');
     }
-  }).drain();
+  }).drain<void>();
   return result;
 }

current_results/lib/src/api_impl.dart

@@ -18,28 +18,28 @@ class QueryService extends QueryServiceBase {
 
   @override
   Future<GetResultsResponse> getResults(
-          ServiceCall call, GetResultsRequest query) =>
-      Future.value(current.results(query));
+          ServiceCall call, GetResultsRequest request) =>
+      Future.value(current.results(request));
 
   @override
   Future<ListTestsResponse> listTests(
-          ServiceCall call, ListTestsRequest query) =>
-      Future.value(current.listTests(query));
+          ServiceCall call, ListTestsRequest request) =>
+      Future.value(current.listTests(request));
 
   @override
   Future<ListTestsResponse> listTestPathCompletions(
-      ServiceCall call, ListTestsRequest query) async {
+      ServiceCall call, ListTestsRequest request) async {
     throw UnimplementedError();
   }
 
   @override
   Future<ListConfigurationsResponse> listConfigurations(
-      ServiceCall call, ListConfigurationsRequest query) async {
+      ServiceCall call, ListConfigurationsRequest request) async {
     throw UnimplementedError;
   }
 
   @override
-  Future<FetchResponse> fetch(ServiceCall call, Empty _) async {
+  Future<FetchResponse> fetch(ServiceCall call, Empty request) async {
     final response = FetchResponse();
     final messages = await notifications.getMessages();
     final latestObjectPattern = RegExp('^(configuration/main/[^/]+/)latest\$');

current_results/lib/src/slice.dart

@@ -67,8 +67,7 @@ class Slice {
   int get size => _size;
 
   void add(List<String> lines) {
-    if (lines.isEmpty) return;
-    var configuration;
+    String? configuration;
     final results = <Result>[];
     for (final line in lines) {
       final result = Result.fromApi(api.Result()
@@ -85,6 +84,9 @@ class Slice {
       _experimentNames.addAll(result.experiments);
       results.add(result);
     }
+    // If there were no results or they were all skips, don't continue.
+    if (configuration == null) return;
+
     final sorted = results.toList()..sort(compareNames);
     _size -= _stored[configuration]?.length ?? 0;
     _stored[configuration] = sorted;
@@ -242,7 +244,7 @@ class Slice {
       Set<String> experimentFilters, PageStart? pageStart,
       {required int needed}) {
     final prefixResult = Result.nameOnly(prefix);
-    var startResult;
+    final Result startResult;
     if (pageStart == null || pageStart.test.compareTo(prefixResult.name) <= 0) {
       startResult = prefixResult;
     } else if (pageStart.test.startsWith(prefixResult.name)) {