Make symbolizer usable as a local tool

The server side symbolizer seems to have fallen over and
maintaining it is too much hassle. Instead make it easy
to run this tool from command line.

Delete all server related code.

Change-Id: Iaf92892e2497595708f40b2f73ba1808896d988f
Reviewed-on: https://dart-review.googlesource.com/c/dart_ci/+/357627
Reviewed-by: William Hesse <[email protected]>

Author: mraleph

github-label-notifier/Dockerfile

@@ -5,7 +5,6 @@ FROM dart:stable AS build
 # Resolve app dependencies.
 WORKDIR /app
 COPY functions/pubspec.* functions/
-COPY symbolizer symbolizer
 WORKDIR /app/functions
 RUN dart pub get
 

github-label-notifier/functions/bin/server.dart

@@ -10,9 +10,6 @@ import 'package:gcp/gcp.dart';
 import 'package:sendgrid_mailer/sendgrid_mailer.dart' as sendgrid;
 import 'package:shelf/shelf.dart';
 import 'package:shelf_router/shelf_router.dart';
-import 'package:symbolizer/model.dart';
-import 'package:symbolizer/parser.dart';
-import 'package:symbolizer/bot.dart';
 
 import 'package:github_label_notifier/github_utils.dart';
 import 'package:github_label_notifier/redirecting_http.dart';
@@ -178,19 +175,13 @@ Sent by dart-github-label-notifier.web.app
 /// The handler will search the body of the open issue for specific keywords
 /// and send emails to all subscribers to a specific label.
 Future<void> onIssueOpened(Map<String, dynamic> event) async {
-  SymbolizationResult? symbolizedCrashes;
-
   final repositoryName = event['repository']['full_name'];
   print("opened issue $repositoryName");
   final subscription = await db.lookupKeywordSubscription(repositoryName);
   if (subscription == null) return;
-  if (subscription.keywords.contains('crash') &&
-      containsCrash(event['issue']['body'])) {
-    symbolizedCrashes = await _trySymbolize(event['issue']);
-  }
 
-  final match = (symbolizedCrashes is SymbolizationResultOk &&
-          symbolizedCrashes.results.isNotEmpty)
+  final match = (subscription.keywords.contains('crash') &&
+          _containsCrash(event['issue']['body']))
       ? 'crash'
       : subscription.match(event['issue']['body']);
   if (match == null) {
@@ -210,51 +201,6 @@ Future<void> onIssueOpened(Map<String, dynamic> event) async {
 
   final escape = htmlEscape.convert;
 
-  final symbolizedCrashesText = symbolizedCrashes
-          ?.when(
-              ok: (results) {
-                return [
-                  '',
-                  ...results.expand((r) => [
-                        if (r.symbolized != null)
-                          '# engine ${r.engineBuild!.engineHash} ${r.engineBuild!.variant.pretty} crash'
-                        else
-                          '# engine crash',
-                        for (var note in r.notes)
-                          if (note.message != null)
-                            '# ${noteMessage[note.kind]}: ${note.message}'
-                          else
-                            '# ${noteMessage[note.kind]}',
-                        r.symbolized ?? r.crash.frames.toString(),
-                      ]),
-                  ''
-                ];
-              },
-              error: (note) => null)
-          ?.join('\n') ??
-      '';
-
-  final symbolizedCrashesHtml = symbolizedCrashes
-          ?.when(
-            ok: (results) {
-              return results.expand((r) => [
-                    if (r.symbolized != null)
-                      '<p>engine ${r.engineBuild!.engineHash} ${r.engineBuild!.variant.pretty} crash</p>'
-                    else
-                      '<p>engine crash</p>',
-                    for (var note in r.notes)
-                      if (note.message != null)
-                        '<em>${noteMessage[note.kind]}: <pre>${escape(note.message!)}</pre></em>'
-                      else
-                        '<em>${noteMessage[note.kind]}</em>',
-                    '<pre>${escape(r.symbolized ?? r.crash.frames.toString())}</pre>',
-                  ]);
-            },
-            error: (note) => null,
-          )
-          ?.join('') ??
-      '';
-
   final personalizations = [
     for (final to in subscribers)
       sendgrid.Personalization([sendgrid.Address(to)])
@@ -270,7 +216,7 @@ $issueUrl
 Reported by $issueReporterUsername
 
 Matches keyword: $match
-$symbolizedCrashesText
+
 You are getting this mail because you are subscribed to label ${subscription.label}.
 --
 Sent by dart-github-label-notifier.web.app
@@ -279,7 +225,6 @@ Sent by dart-github-label-notifier.web.app
 <p><strong><a href="$issueUrl">${escape(issueTitle)}</a>&nbsp;(${escape(repositoryName)}#${escape(issueNumber.toString())})</strong></p>
 <p>Reported by <a href="$issueReporterUrl">${escape(issueReporterUsername)}</a></p>
 <p>Matches keyword: <b>$match</b></p>
-$symbolizedCrashesHtml
 <p>You are getting this mail because you are subscribed to label ${subscription.label}</p>
 <hr>
 <p>Sent by <a href="https://dart-github-label-notifier.web.app/">GitHub Label Notifier</a></p>
@@ -292,18 +237,7 @@ $symbolizedCrashesHtml
 }
 
 Future<void> onIssueCommentCreated(Map<String, dynamic> event) async {
-  final body = event['comment']['body'];
-
-  if (Bot.isCommand(body)) {
-    final response = await http.post(
-      Uri.http(symbolizerServer, 'command'),
-      body: jsonEncode(event),
-    );
-    if (response.statusCode != HttpStatus.ok) {
-      throw WebHookError(HttpStatus.internalServerError,
-          'Failed to process ${event['comment']['html_url']}: ${response.body}');
-    }
-  }
+  // Do nothing.
 }
 
 class WebHookError {
@@ -324,23 +258,6 @@ String getRequiredHeaderValue(Request request, String header) {
           HttpStatus.badRequest, 'Missing $header header value.'));
 }
 
-Future<SymbolizationResult> _trySymbolize(Map<String, dynamic> body) async {
-  try {
-    final response = await http
-        .post(
-          Uri.http(symbolizerServer, 'symbolize'),
-          body: jsonEncode(body),
-        )
-        .timeout(const Duration(seconds: 20));
-    return SymbolizationResult.fromJson(jsonDecode(response.body));
-  } catch (e, st) {
-    return SymbolizationResult.error(
-        error: SymbolizationNote(
-            kind: SymbolizationNoteKind.exceptionWhileSymbolizing,
-            message: '$e\n$st'));
-  }
-}
-
 Future<http.Response> Function(Uri url,
     {Object? body,
     Encoding? encoding,
@@ -351,3 +268,14 @@ Future<http.Response> Function(Uri url,
     return http.post(newUrl, body: body, encoding: encoding, headers: headers);
   };
 }
+
+final _androidCrashMarker =
+    '*** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***';
+
+final _iosCrashMarker = RegExp(
+    r'(Incident Identifier:\s+([A-F0-9]+-?)+)|(Exception Type:\s+EXC_CRASH)');
+
+/// Returns [true] if the given text is likely to contain a crash.
+bool _containsCrash(String text) {
+  return text.contains(_androidCrashMarker) || text.contains(_iosCrashMarker);
+}

github-label-notifier/functions/pubspec.lock

@@ -13,18 +13,18 @@ packages:
     dependency: transitive
     description:
       name: _fe_analyzer_shared
-      sha256: "0816708f5fbcacca324d811297153fe3c8e047beb5c6752e12292d2974c17045"
+      sha256: eb376e9acf6938204f90eb3b1f00b578640d3188b4c8a8ec054f9f479af8d051
       url: "https://pub.dev"
     source: hosted
-    version: "62.0.0"
+    version: "64.0.0"
   analyzer:
     dependency: transitive
     description:
       name: analyzer
-      sha256: "21862995c9932cd082f89d72ae5f5e2c110d1a0204ad06e4ebaee8307b76b834"
+      sha256: "69f54f967773f6c26c7dcb13e93d7ccee8b17a641689da39e878d5cf13b06893"
       url: "https://pub.dev"
     source: hosted
-    version: "6.0.0"
+    version: "6.2.0"
   args:
     dependency: transitive
     description:
@@ -33,14 +33,6 @@ packages:
       url: "https://pub.dev"
     source: hosted
     version: "2.4.2"
-  asn1lib:
-    dependency: transitive
-    description:
-      name: asn1lib
-      sha256: b74e3842a52c61f8819a1ec8444b4de5419b41a7465e69d4aa681445377398b0
-      url: "https://pub.dev"
-    source: hosted
-    version: "1.4.1"
   async:
     dependency: "direct main"
     description:
@@ -73,14 +65,6 @@ packages:
       url: "https://pub.dev"
     source: hosted
     version: "3.1.1"
-  corsac_jwt:
-    dependency: transitive
-    description:
-      name: corsac_jwt
-      sha256: f86d1a1ad7d4db5727ae5d68dfd4437cbcf62daabe920190fcd5425457f5f377
-      url: "https://pub.dev"
-    source: hosted
-    version: "1.0.0-nullsafety.1"
   coverage:
     dependency: transitive
     description:
@@ -97,14 +81,6 @@ packages:
       url: "https://pub.dev"
     source: hosted
     version: "3.0.3"
-  dart_internal:
-    dependency: transitive
-    description:
-      name: dart_internal
-      sha256: dae3976f383beddcfcd07ad5291a422df2c8c0a8a03c52cda63ac7b4f26e0f4e
-      url: "https://pub.dev"
-    source: hosted
-    version: "0.2.8"
   file:
     dependency: transitive
     description:
@@ -113,14 +89,6 @@ packages:
       url: "https://pub.dev"
     source: hosted
     version: "7.0.0"
-  freezed_annotation:
-    dependency: transitive
-    description:
-      name: freezed_annotation
-      sha256: aeac15850ef1b38ee368d4c53ba9a847e900bb2c53a4db3f6881cbb3cb684338
-      url: "https://pub.dev"
-    source: hosted
-    version: "2.2.0"
   frontend_server_client:
     dependency: transitive
     description:
@@ -137,14 +105,6 @@ packages:
       url: "https://pub.dev"
     source: hosted
     version: "0.1.1"
-  github:
-    dependency: transitive
-    description:
-      name: github
-      sha256: "5640619ae3780877fe62b7837b41343350acc845c528f7b339c34c60745f2cdd"
-      url: "https://pub.dev"
-    source: hosted
-    version: "9.15.1"
   glob:
     dependency: transitive
     description:
@@ -217,14 +177,6 @@ packages:
       url: "https://pub.dev"
     source: hosted
     version: "0.6.7"
-  json_annotation:
-    dependency: transitive
-    description:
-      name: json_annotation
-      sha256: b10a7b2ff83d83c777edba3c6a0f97045ddadd56c944e1a23a3fdf43a1bf4467
-      url: "https://pub.dev"
-    source: hosted
-    version: "4.8.1"
   lints:
     dependency: "direct dev"
     description:
@@ -289,22 +241,6 @@ packages:
       url: "https://pub.dev"
     source: hosted
     version: "1.8.3"
-  pedantic:
-    dependency: transitive
-    description:
-      name: pedantic
-      sha256: "67fc27ed9639506c856c840ccce7594d0bdcd91bc8d53d6e52359449a1d50602"
-      url: "https://pub.dev"
-    source: hosted
-    version: "1.11.1"
-  pointycastle:
-    dependency: transitive
-    description:
-      name: pointycastle
-      sha256: "7c1e5f0d23c9016c5bbd8b1473d0d3fb3fc851b876046039509e18e0c7485f2c"
-      url: "https://pub.dev"
-    source: hosted
-    version: "3.7.3"
   pool:
     dependency: transitive
     description:
@@ -321,14 +257,6 @@ packages:
       url: "https://pub.dev"
     source: hosted
     version: "2.1.4"
-  rsa_pkcs:
-    dependency: transitive
-    description:
-      name: rsa_pkcs
-      sha256: "17a52b0c010319f0d4c7bcc635eb89e2efeaec44975b3fb45f850b350a2b0513"
-      url: "https://pub.dev"
-    source: hosted
-    version: "2.0.1"
   sendgrid_mailer:
     dependency: "direct main"
     description:
@@ -425,13 +353,6 @@ packages:
       url: "https://pub.dev"
     source: hosted
     version: "1.2.0"
-  symbolizer:
-    dependency: "direct main"
-    description:
-      path: "../symbolizer"
-      relative: true
-    source: path
-    version: "0.0.1"
   term_glyph:
     dependency: transitive
     description:
@@ -513,4 +434,4 @@ packages:
     source: hosted
     version: "3.1.2"
 sdks:
-  dart: ">=3.0.0 <3.2.0"
+  dart: ">=3.0.0 <4.0.0"

github-label-notifier/functions/pubspec.yaml

@@ -20,8 +20,6 @@ dependencies:
   shelf: ^1.4.0
   shelf_router: ^1.1.3
   test: any
-  symbolizer:
-    path: ../symbolizer
 
 dev_dependencies:
   lints: ^2.0.1