Skip to content

Commit 7cc3191

Browse files
committed
base64 encode data-dismiss-message-id in localStorage
1 parent 204ba6a commit 7cc3191

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

pkg/web_app/lib/src/widget/dismiss/widget.dart

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,8 @@ void create(HTMLElement element, Map<String, String> options) {
8181
/// Data is stored on the format: `<message-id>@<date>;<message-id>@<date>;...`,
8282
/// where:
8383
/// * `<date>` is on the form `YYYY-MM-DD`.
84-
/// * `<message-id>` is the `data-dismiss-message-id` passed to a dismiss
85-
/// widget.
84+
/// * `<message-id>` is the base64 encoded `data-dismiss-message-id` passed to
85+
/// a dismiss widget.
8686
const _dismissedMessageslocalStorageKey = 'dismissed-messages';
8787

8888
late final _dismissed = [
@@ -93,7 +93,7 @@ late final _dismissed = [
9393
.map((entry) {
9494
final [id, date, ...] = entry.split('@');
9595
return (
96-
id: id,
96+
id: window.atob(id),
9797
date: DateTime.tryParse(date) ?? DateTime.fromMicrosecondsSinceEpoch(0),
9898
);
9999
}).where((entry) => entry.date.isAfter(_deadline)),
@@ -106,7 +106,12 @@ void _saveDismissed() {
106106
.sortedBy((e) => e.date) // Sort by date
107107
.reversed // Reverse ordering to prefer newest dates
108108
.take(_maxMissedMessages) // Limit how many entries we save
109-
.map((e) => e.id + '@' + e.date.toIso8601String().split('T').first)
109+
.map(
110+
(e) =>
111+
window.btoa(e.id) +
112+
'@' +
113+
e.date.toIso8601String().split('T').first,
114+
)
110115
.join(';'),
111116
);
112117
}

0 commit comments

Comments
 (0)