Improve banner CSS #8092
Merged
Improve banner CSS #8092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* On standalone pages the banner will sit in page and be hidden. * On package page (and landing page) the banner will float over content with position absolute, as these pages have sufficient margin to allow for this. In both cases content will not jump when the banner is dismissed, or when the banner is loaded.
isoos
approved these changes
Oct 1, 2024
|
Pushed to |
jonasfj
force-pushed
the
improved-banner-css
branch
from
01d3d31 to
ff418d7
Compare
isoos
approved these changes
Oct 3, 2024
|
|
||
| .dismisser { | ||
| float: right; | ||
| position: absolute; |
There was a problem hiding this comment.
Not sure: does this need a position: relative in the parent element?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In both cases content will not jump when the banner is dismissed, or when the banner is loaded.