[analysis_server] Use only Parsed AST for format in legacy protocol handler

+ clean up LSP version to use new `unit.languageVersion.effective`

Fixes #56960

Change-Id: Ia28f3ddb116427ecd8588f58adb7238a7204832a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/391961
Reviewed-by: Brian Wilkerson <[email protected]>
Reviewed-by: Bob Nystrom <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>

Author: DanTup

pkg/analysis_server/lib/src/handler/legacy/edit_format.dart

@@ -12,7 +12,6 @@ import 'package:analyzer_plugin/protocol/protocol_common.dart';
 import 'package:dart_style/src/dart_formatter.dart';
 import 'package:dart_style/src/exceptions.dart';
 import 'package:dart_style/src/source_code.dart';
-import 'package:pub_semver/pub_semver.dart';
 
 /// The handler for the `edit.format` request.
 class EditFormatHandler extends LegacyHandler {
@@ -27,11 +26,9 @@ class EditFormatHandler extends LegacyHandler {
         clientUriConverter: server.uriConverter);
     var file = params.file;
 
-    String unformattedCode;
-    try {
-      var resource = server.resourceProvider.getFile(file);
-      unformattedCode = resource.readAsStringSync();
-    } catch (e) {
+    var driver = server.getAnalysisDriver(file);
+    var unit = driver?.parseFileSync(file);
+    if (unit is! ParsedUnitResult) {
       sendResponse(Response.formatInvalidFile(request));
       return;
     }
@@ -45,29 +42,18 @@ class EditFormatHandler extends LegacyHandler {
       length = null;
     }
 
+    var unformattedCode = unit.content;
     var code = SourceCode(
       unformattedCode,
       selectionStart: start,
       selectionLength: length,
     );
 
-    var driver = server.getAnalysisDriver(file);
-    var unit = await driver?.getResolvedUnit(file);
-
-    int? pageWidth;
-    Version effectiveLanguageVersion;
-    if (unit is ResolvedUnitResult) {
-      pageWidth = unit.analysisOptions.formatterOptions.pageWidth;
-      effectiveLanguageVersion = unit.libraryElement2.effectiveLanguageVersion;
-    } else {
-      // If the unit doesn't resolve, don't try to format it since we don't
-      // know what language version (and thus what formatting style) to apply.
-      sendResponse(Response.formatWithErrors(request));
-      return;
-    }
-
+    var effectivePageWidth =
+        unit.analysisOptions.formatterOptions.pageWidth ?? params.lineLength;
+    var effectiveLanguageVersion = unit.unit.languageVersion.effective;
     var formatter = DartFormatter(
-        pageWidth: pageWidth ?? params.lineLength,
+        pageWidth: effectivePageWidth,
         languageVersion: effectiveLanguageVersion);
     SourceCode formattedResult;
     try {

pkg/analysis_server/lib/src/lsp/source_edits.dart

@@ -13,12 +13,10 @@ import 'package:analyzer/dart/ast/token.dart';
 import 'package:analyzer/error/listener.dart';
 import 'package:analyzer/source/line_info.dart';
 import 'package:analyzer/source/source.dart';
-import 'package:analyzer/src/dart/analysis/results.dart';
 import 'package:analyzer/src/dart/scanner/reader.dart';
 import 'package:analyzer/src/dart/scanner/scanner.dart';
 import 'package:analyzer_plugin/protocol/protocol_common.dart' as plugin;
 import 'package:dart_style/dart_style.dart';
-import 'package:pub_semver/pub_semver.dart';
 
 /// Checks whether a string contains only characters that are allowed to differ
 /// between unformattedformatted code (such as whitespace, commas, semicolons).
@@ -98,11 +96,7 @@ ErrorOr<List<TextEdit>?> generateEditsForFormatting(
   // the LSP configuration.
   var effectivePageWidth =
       result.analysisOptions.formatterOptions.pageWidth ?? defaultPageWidth;
-
-  var effectiveLanguageVersion = switch (result.unit.languageVersionToken) {
-    var token? => Version(token.major, token.minor, 0),
-    _ => (result as ParsedUnitResultImpl).fileState.packageLanguageVersion,
-  };
+  var effectiveLanguageVersion = result.unit.languageVersion.effective;
 
   var code = SourceCode(unformattedSource);
   SourceCode formattedResult;