Commit 92a5336
committed
Fix awaiting for future
In #2491, the reloader was changed to
pass two arguments instead of an object with two fields into dartLibrary.reload.
As a result, the javascript side couldn't find the promise in a field of the
first argument and ignored the second argument. Usually it is fine, but this
broke postponing main launch until the attached debugger can configure breakpoints.
Again, this is not a big deal for interactive long-running apps, but if the main is
fast and short (e.g. tests), this effectively prevents interactive debugging from an IDE.1 parent a407cc1 commit 92a5336
1 file changed
+14
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
17 | 27 | | |
18 | 28 | | |
19 | 29 | | |
| |||
27 | 37 | | |
28 | 38 | | |
29 | 39 | | |
30 | | - | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
31 | 43 | | |
32 | 44 | | |
33 | 45 | | |
| |||
0 commit comments