Skip to content

enh: default props #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
goanpeca merged 4 commits into from
Dec 1, 2025
Merged

enh: default props #430

goanpeca merged 4 commits into from
Dec 1, 2025

Conversation

@echarles
Copy link
Member

@echarles echarles commented Nov 29, 2025

No description provided.

@echarles echarles requested a review from goanpeca November 29, 2025 06:11
@echarles echarles marked this pull request as ready for review November 29, 2025 06:54
@echarles
Copy link
Member Author

echarles commented Nov 29, 2025

@goanpeca not sure why CI is showing those prettier errors (I can not reproduce them on my laptop)

 Checking formatting...
  [warn] packages/react/src/jupyter/collaboration/ICollaborationProvider.ts
  [warn] packages/react/src/theme/JupyterLabCss.tsx
  [warn] storybook/src/stories/Cell.stories.tsx
  [warn] storybook/src/stories/Console.stories.tsx
  [warn] storybook/src/stories/Notebook.stories.tsx
  [warn] Code style issues found in 5 files. Run Prettier with --write to fix.
  Error: Process completed with exit code 1.

goanpeca
goanpeca approved these changes Dec 1, 2025
View reviewed changes
Copy link
Collaborator

@goanpeca goanpeca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! 🚀

Thanks!

@goanpeca goanpeca merged commit 654a242 into main Dec 1, 2025
9 of 10 checks passed
@goanpeca goanpeca deleted the fix/default-props branch December 1, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goanpeca goanpeca goanpeca approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@echarles @goanpeca