Skip to content

Commit a15eed3

Browse files
CNDB-15554: Bump jvector version
1 parent 581164b commit a15eed3

File tree

5 files changed

+20
-14
lines changed

5 files changed

+20
-14
lines changed

build.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -741,7 +741,7 @@
741741
<dependency groupId="org.apache.lucene" artifactId="lucene-core" version="9.8.0" />
742742
<dependency groupId="org.apache.lucene" artifactId="lucene-analysis-common" version="9.8.0" />
743743
<dependency groupId="org.apache.lucene" artifactId="lucene-backward-codecs" version="9.8.0" />
744-
<dependency groupId="io.github.jbellis" artifactId="jvector" version="4.0.0-rc.3" />
744+
<dependency groupId="io.github.jbellis" artifactId="jvector" version="4.0.0-rc.5-SNAPSHOT" />
745745
<dependency groupId="com.bpodgursky" artifactId="jbool_expressions" version="1.14" scope="test"/>
746746

747747
<dependency groupId="com.carrotsearch.randomizedtesting" artifactId="randomizedtesting-runner" version="2.1.2" scope="test">

src/java/org/apache/cassandra/index/sai/disk/vector/CassandraDiskAnn.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
import org.slf4j.Logger;
2828
import org.slf4j.LoggerFactory;
2929

30-
import io.github.jbellis.jvector.graph.GraphIndex;
30+
import io.github.jbellis.jvector.graph.ImmutableGraphIndex;
3131
import io.github.jbellis.jvector.graph.GraphSearcher;
3232
import io.github.jbellis.jvector.graph.disk.feature.FeatureId;
3333
import io.github.jbellis.jvector.graph.disk.OnDiskGraphIndex;
@@ -72,7 +72,7 @@ public class CassandraDiskAnn
7272
private final FileHandle graphHandle;
7373
private final OnDiskOrdinalsMap ordinalsMap;
7474
private final Set<FeatureId> features;
75-
private final GraphIndex graph;
75+
private final ImmutableGraphIndex graph;
7676
private final VectorSimilarityFunction similarityFunction;
7777
@Nullable
7878
private final CompressedVectors compressedVectors;
@@ -231,7 +231,7 @@ public CloseableIterator<RowIdWithScore> search(VectorFloat<?> queryVector,
231231
searcher.usePruning(usePruning);
232232
try
233233
{
234-
var view = (GraphIndex.ScoringView) searcher.getView();
234+
var view = (ImmutableGraphIndex.ScoringView) searcher.getView();
235235
SearchScoreProvider ssp;
236236
// FusedADC can no longer be written due to jvector upgrade. However, it's possible these index files
237237
// still exist, so we have to support them.
@@ -311,9 +311,9 @@ public OrdinalsView getOrdinalsView()
311311
return ordinalsMap.getOrdinalsView();
312312
}
313313

314-
public GraphIndex.ScoringView getView()
314+
public ImmutableGraphIndex.ScoringView getView()
315315
{
316-
return (GraphIndex.ScoringView) graph.getView();
316+
return (ImmutableGraphIndex.ScoringView) graph.getView();
317317
}
318318

319319
public boolean containsUnitVectors()

src/java/org/apache/cassandra/index/sai/disk/vector/CloseableReranker.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,21 +20,21 @@
2020

2121
import java.io.Closeable;
2222

23-
import io.github.jbellis.jvector.graph.GraphIndex;
23+
import io.github.jbellis.jvector.graph.ImmutableGraphIndex;
2424
import io.github.jbellis.jvector.graph.similarity.ScoreFunction;
2525
import io.github.jbellis.jvector.vector.VectorSimilarityFunction;
2626
import io.github.jbellis.jvector.vector.types.VectorFloat;
2727
import org.apache.cassandra.io.util.FileUtils;
2828

2929
/**
30-
* An ExactScoreFunction that closes the underlying {@link GraphIndex.ScoringView} when closed.
30+
* An ExactScoreFunction that closes the underlying {@link ImmutableGraphIndex.ScoringView} when closed.
3131
*/
3232
public class CloseableReranker implements ScoreFunction.ExactScoreFunction, Closeable
3333
{
34-
private final GraphIndex.ScoringView view;
34+
private final ImmutableGraphIndex.ScoringView view;
3535
private final ExactScoreFunction scoreFunction;
3636

37-
public CloseableReranker(VectorSimilarityFunction similarityFunction, VectorFloat<?> queryVector, GraphIndex.ScoringView view)
37+
public CloseableReranker(VectorSimilarityFunction similarityFunction, VectorFloat<?> queryVector, ImmutableGraphIndex.ScoringView view)
3838
{
3939
this.view = view;
4040
this.scoreFunction = view.rerankerFor(queryVector, similarityFunction);

src/java/org/apache/cassandra/index/sai/disk/vector/CompactionGraph.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -372,7 +372,7 @@ public long addGraphNode(InsertionResult result)
372372
public SegmentMetadata.ComponentMetadataMap flush() throws IOException
373373
{
374374
// header is required to write the postings, but we need to recreate the writer after that with an accurate OrdinalMapper
375-
writer.writeHeader();
375+
writer.writeHeader(builder.getGraph().getView());
376376
writer.close();
377377

378378
int nInProgress = builder.insertsInProgress();

test/unit/org/apache/cassandra/index/sai/disk/vector/BruteForceRowIdIteratorTest.java

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
import org.junit.Test;
2424

25-
import io.github.jbellis.jvector.graph.GraphIndex;
25+
import io.github.jbellis.jvector.graph.ImmutableGraphIndex;
2626
import io.github.jbellis.jvector.graph.NodeQueue;
2727
import io.github.jbellis.jvector.graph.NodesIterator;
2828
import io.github.jbellis.jvector.graph.similarity.ScoreFunction;
@@ -63,7 +63,7 @@ public void testBruteForceRowIdIteratorForEmptyPQAndTopKEqualsLimit()
6363
assertTrue(view.isClosed);
6464
}
6565

66-
private static class TestView implements GraphIndex.ScoringView
66+
private static class TestView implements ImmutableGraphIndex.ScoringView
6767
{
6868
private boolean isClosed = false;
6969

@@ -102,7 +102,7 @@ public int size()
102102
}
103103

104104
@Override
105-
public GraphIndex.NodeAtLevel entryNode()
105+
public ImmutableGraphIndex.NodeAtLevel entryNode()
106106
{
107107
throw new UnsupportedOperationException();
108108
}
@@ -112,5 +112,11 @@ public Bits liveNodes()
112112
{
113113
throw new UnsupportedOperationException();
114114
}
115+
116+
@Override
117+
public boolean contains(int i, int i1)
118+
{
119+
return false;
120+
}
115121
}
116122
}

0 commit comments

Comments
 (0)