fix(FE): using save icon instead of download icon #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarthak-kumar-shailendra
changed the title
sarthak-kumar-shailendra
force-pushed
the
SS/FixSaveIcon
branch
from
9883324 to
194a8b6
Compare
* chore: add comments * chore: 🚨 lint fix
…atazip-inc#195) * feat: add error logs i check conenction for source and destination * fix: parse json message as string * chore: update response key * chore: refactor * chore: remove logEntry struct * fix: log parsing * fix: log parsing * fix: logs parsing logic * docs: updated api contract
…ogs-in-test-connection feat: show error logs in test connection
* test: ✅ base setup for automation testing using playwright , add test cases fro major flows * fix: integration workflow changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * test: add postgres flow * fix: lint changes * test: add iceberg specific test * fix: tests * fix: stream name * fix: test fix * fix: test fix * fix: test fix * fix: test fix * fix: changes * fix: ci changes * fix: ci changes * fix: ci changes * test: fail test on test connection failure * fix: ci changes * fix: changes * fix: changes * fix: changes * fix: changes * fix: changes * fix: changes * fix: test fix * fix: changes * fix: changes * fix: test-data fix * fix: test-data fix * fix: changes * fix: changes * fix: changes * fix: host and port changes * fix: changes * fix: change * test: login test updated * test: refactor create source and destination page * test: refactor tests * fix: test fix * fix: changes * fix: fix changes * fix: changes * fix: changes * fix: review changes * refactor: refactor tests to use authenticated state of playwright * fix: changes * docs: update tests readme * test: intercept and log destination spec response * docs: update readme * fix: update timeouts for playwright tests * test: update readme * fix: add retries in playwright config * test: fix timeout duration * fix: update readme * test: add connector data test-id * fix: resolve comments * refactor(test): make and use enums instead of strings * fix: fix test data builder * fix: test data job name * fix: add todo --------- Co-authored-by: Duke Dhal <[email protected]> Co-authored-by: deepanshupal09-datazip <[email protected]>
* Added success message on Job History refetch * Update ui/src/modules/jobs/pages/JobHistory.tsx Co-authored-by: deepanshupal09-datazip <[email protected]> --------- Co-authored-by: vikash choudhary <[email protected]> Co-authored-by: deepanshupal09-datazip <[email protected]>
…datazip-inc#216) * fix: replace deprecated Phosphor icons with latest *Icon alternatives * fix: update Phosphor icons to latest alternatives in DestinationEdit and SourceEdit components and fix Lint issue * refactor: remove EditSourceModal * fix: update icon import --------- Co-authored-by: vikash choudhary <[email protected]>
* feat: add append only mode in ui * fix: data filter bug * fix: fix color of append only mode switch * fix: add custom option in all streams ingestion mode change * fix: use clsx for conditional styling * fix: fix icons
* fix(api): refactor raw queries and add constants * chore(api): Adding service layer * chore(api): adding service layer * fix: resolve conflict errors * feat: improve Worker design by passing existing Client * feat: improving error handling a * feat: add info logging * fix: changes after testing * feat(docker): use Docker Go SDK instead of shell commands for container operations * feat: updated GoSec security ci * feat: delete config files * chore: update project name to olake-ui * chore: addressed review comments * chore: creatign dto packaghe * chore: using GetIDFromPath function for id * feat: implement dto layer and validation for request * merge staging * chore: refactor based on self review * chore: refactor * docs: updated api contract * refactor: initialize services once at startup and standardize error logging * fix: remove unnecessary checks * fix: ci issues * fix: ci issues * fix: ci issues * fix: lint issues * fix: refactor unmarshal and validation for req body * chore: refactor dto and nil checks * chore: use errorf * fix: dto and db queries * chore: resovle review comments * chore: remove nil checks and added request uri in error logs * fix: lint issue * chore: refactor bff (datazip-inc#237) * chore: refactored refactor pr * chore: some more refactor related changes * chore: refactor temporal service * chore: remove comments * chore: refactor error throwing * chore: updating handler * chore: rename service and db thing * chore: adding back vikash commit of package name change * chore: adding back vikash commit of package name change * refactor: merge k8s and docker workers (datazip-inc#205) * fix: commands -> check, discover * fix: sync worklfow * refactor: remove worker from olake-ui * chore: remove worker files & add timeout utility * chore: update branch name in worklfow to release an image * fix: remove worker from release.sh * fix: add pre and post sync worker callback * fix: add telemetry event for sync workflow * fix: latest changes * chore: remove stale code * fix: update env var - container_persistence_dir and host_persistence_dir * chore: remove worker job api * chore: cleanup files * fix: fix refactor bff changes * chore: move encryptionkey to app.conf * chore: add unmarshal-and-validate util * chore: add robust error logging (resolve comments) * chore: remove container_persistent_path env var * fix: update sync workflow to match the old worker * chore: add wrong workflow name * chore: add correct workflow name * fix: resolve comments * chore: add constants for app.conf keys * fix: call pause and unpause in activate job service * chore: api success response update * fix: lint issue * fix: source and job dataitems * fix: api according to bff refactor * fix: build errors * chore: consistant logger accorss files * fix: security ci * fix: security ci * fix: panic issue and add unique name check in job creation * feat: added job cancel in job updatea and return error from test connection * chore: move temporal and etl into services folder * chore: use same name in sevice and handlers * fix: source test connection * fix: move result nil check before error in source and destiantion test connection * fix: fix job history retry and destination spec api (datazip-inc#244) * fix: fix job history retry * fix: fix destination spec api * fix: remove hardcoding branch name in build-ui workflow * fix: remove k8s and docker task queue * fix: lint issue * fix: error in login and test destiantion * fix: add retry logic for temporal client init * fix: send id in job edit (datazip-inc#245) * fix: send id in job edit * fix: add modal for spec error, fix double error messages * fix: integration test fix * fix: minor fix * chore: update worker tag in docker-compose for int. test * chore: remove temporal address from constant (datazip-inc#246) * chore: remove temporalAddr constant and make retry simple * chore: remove logs * fix: add cleanup on cancelling fetchSpec API * chore: resolve review comments * chore: remove unused messages * fix: integration test - attempt 1 * chore: added a todo --------- Co-authored-by: Ankit Sharma <[email protected]> Co-authored-by: hashcode-ankit <[email protected]> Co-authored-by: vishal-datazip <[email protected]> Co-authored-by: deepanshupal09-datazip <[email protected]>
Author
|
@Akshay-datazip Please review |
Akshay-datazip
previously approved these changes
Nov 9, 2025
deepanshupal09-datazip
dismissed
Akshay-datazip’s stale review
The base branch was changed.
shubham19may
force-pushed
the
staging
branch
from
0c10a25 to
8335e7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Save icon (commonly a floppy disk or similar) should be used to represent the save action, clearly indicating the intent to persist or store data.
Fixes #213
Type of change
How Has This Been Tested?
Screenshots or Recordings
Related PR's (If Any):