Skip to content

Is it possible for the GH Action to also publish PR-previews on a subdomain? #69

@bumblefudge

Description

@bumblefudge

In addition to #20 , I think it would be neat to have PRs link automatically to their previews, as ReSpec and the IETF publication tools do. the "files" tab is good enough as a diff-view since it's just markdown, but for diagrams and big PRs having a full rendered preview seems worth the hassle. For example, the GH Actions workflow could, upon each new PR, run the build script and publish the resulting site in a path like preview/pr123/, then output that link in the PR as a separate comment. This could be re-run manually if big PRs change substantially over time.

The biggest counterargument/downside to this is that historically, not all spec-up editors used relative links 100% of the time, so previews would have lots of broken image tags and such in those cases. Perhaps the same PR that changes the GH action could also include add stronger language to the readme and spec-site insisting on rel-refs 😄

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions