fix: token and caps array mismatch

Author: 0xAustrian

src/contracts/action-hubs/CappedTokenTransfersHub.sol

@@ -52,6 +52,7 @@ contract CappedTokenTransfersHub is ActionHub, ICappedTokenTransfersHub, SafeMan
     EPOCH_LENGTH = _epochLength;
     lastEpoch = block.timestamp;
 
+    if (_tokens.length != _caps.length) revert TokensAndCapsLengthMismatch();
     if (_epochLength == 0) revert EpochLengthCannotBeZero();
 
     for (uint256 i = 0; i < _tokens.length; i++) {

src/interfaces/action-hubs/ICappedTokenTransfersHub.sol

@@ -50,6 +50,11 @@ interface ICappedTokenTransfersHub is IActionHub, ISafeManageable {
    */
   error TokenAlreadyRegisteredInHub(address _token);
 
+  /**
+   * @notice Thrown when the tokens and caps length mismatch
+   */
+  error TokensAndCapsLengthMismatch();
+
   // ~~~ FUNCTIONS ~~~
 
   /**

test/unit/actions-hubs/CappedTokenTransfersHub.t.sol

@@ -80,6 +80,21 @@ contract UnitCappedTokenTransfersHub is Test {
     new CappedTokenTransfersHub(safe, recipient, tokens, caps, 0);
   }
 
+  function test_Constructor_WhenTheTokensAndCapsLengthMismatch() external {
+    tokens = new address[](2);
+    tokens[0] = makeAddr('token1');
+    tokens[1] = makeAddr('token2');
+
+    caps = new uint256[](3);
+    caps[0] = 100;
+    caps[1] = 200;
+    caps[2] = 300;
+
+    // it reverts
+    vm.expectRevert(ICappedTokenTransfersHub.TokensAndCapsLengthMismatch.selector);
+    new CappedTokenTransfersHub(safe, recipient, tokens, caps, EPOCH_LENGTH);
+  }
+
   modifier whenCalledByTheSafeOwner() {
     vm.mockCall(address(safe), abi.encodeWithSelector(IOwnerManager.isOwner.selector), abi.encode(true));
     _;

test/unit/actions-hubs/CappedTokenTransfersHub.tree

@@ -6,7 +6,9 @@ UnitCappedTokenTransfersHub::constructor
 │   └── it sets the tokens and caps
 ├── When tokens registered contain a duplicated token
 │   └── it reverts
-└── When the epoch length is zero
+├── When the epoch length is zero
+│   └── it reverts
+└── When the tokens and caps length mismatch
     └── it reverts
 
 UnitCappedTokenTransfersHub::createNewActionsBuilder