Skip to content

Commit 6a5956c

Browse files
jalextowlejrhea
andauthored
Added Natspec to the interfaces (#751)
* Documented all of the functions, events, and errors in the interfaces * Added better Natspec documentation to `Hyperdrive` * Update contracts/src/interfaces/IERC20Forwarder.sol Co-authored-by: Jonny Rhea <[email protected]> * Update contracts/src/interfaces/IHyperdriveCore.sol Co-authored-by: Jonny Rhea <[email protected]> * Addressed review feedback from @jrhea --------- Co-authored-by: Jonny Rhea <[email protected]>
1 parent d363f42 commit 6a5956c

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

46 files changed

+602
-140
lines changed

contracts/src/deployers/HyperdriveDeployerCoordinator.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ abstract contract HyperdriveDeployerCoordinator is
9292
/// @param _deployConfig The deploy configuration of the Hyperdrive pool.
9393
/// @param _extraData The extra data that contains the pool and sweep targets.
9494
/// @param _salt The create2 salt used to deploy Hyperdrive.
95-
/// @return The address of the newly deployed ERC4626Hyperdrive Instance.
95+
/// @return The address of the newly deployed Hyperdrive instance.
9696
function deploy(
9797
bytes32 _deploymentId,
9898
IHyperdrive.PoolDeployConfig memory _deployConfig,

contracts/src/deployers/erc4626/ERC4626HyperdriveCoreDeployer.sol

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -16,33 +16,33 @@ contract ERC4626HyperdriveCoreDeployer is IHyperdriveCoreDeployer {
1616
/// @notice Deploys a Hyperdrive instance with the given parameters.
1717
/// @param _config The configuration of the Hyperdrive pool.
1818
/// @param _extraData The extra data that contains the ERC4626 vault.
19-
/// @param target0 The target0 address.
20-
/// @param target1 The target1 address.
21-
/// @param target2 The target2 address.
22-
/// @param target3 The target3 address.
23-
/// @param target4 The target4 address.
19+
/// @param _target0 The target0 address.
20+
/// @param _target1 The target1 address.
21+
/// @param _target2 The target2 address.
22+
/// @param _target3 The target3 address.
23+
/// @param _target4 The target4 address.
2424
/// @param _salt The create2 salt used in the deployment.
2525
/// @return The address of the newly deployed ERC4626Hyperdrive instance.
2626
function deploy(
2727
IHyperdrive.PoolConfig memory _config,
2828
bytes memory _extraData,
29-
address target0,
30-
address target1,
31-
address target2,
32-
address target3,
33-
address target4,
29+
address _target0,
30+
address _target1,
31+
address _target2,
32+
address _target3,
33+
address _target4,
3434
bytes32 _salt
3535
) external returns (address) {
3636
address vault = abi.decode(_extraData, (address));
3737
return (
3838
address(
3939
new ERC4626Hyperdrive{ salt: _salt }(
4040
_config,
41-
target0,
42-
target1,
43-
target2,
44-
target3,
45-
target4,
41+
_target0,
42+
_target1,
43+
_target2,
44+
_target3,
45+
_target4,
4646
IERC4626(vault)
4747
)
4848
)

contracts/src/deployers/erc4626/ERC4626Target0Deployer.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ contract ERC4626Target0Deployer is IHyperdriveTargetDeployer {
1717
/// @param _config The configuration of the Hyperdrive pool.
1818
/// @param _extraData The extra data that contains the pool and sweep targets.
1919
/// @param _salt The create2 salt used in the deployment.
20-
/// @return The address of the newly deployed ERC4626Target0 Instance.
20+
/// @return The address of the newly deployed ERC4626Target0 instance.
2121
function deploy(
2222
IHyperdrive.PoolConfig memory _config,
2323
bytes memory _extraData,

contracts/src/deployers/erc4626/ERC4626Target1Deployer.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ contract ERC4626Target1Deployer is IHyperdriveTargetDeployer {
1717
/// @param _config The configuration of the Hyperdrive pool.
1818
/// @param _extraData The extra data that contains the pool and sweep targets.
1919
/// @param _salt The create2 salt used in the deployment.
20-
/// @return The address of the newly deployed ERC4626Target1 Instance.
20+
/// @return The address of the newly deployed ERC4626Target1 instance.
2121
function deploy(
2222
IHyperdrive.PoolConfig memory _config,
2323
bytes memory _extraData,

contracts/src/deployers/erc4626/ERC4626Target2Deployer.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ contract ERC4626Target2Deployer is IHyperdriveTargetDeployer {
1717
/// @param _config The configuration of the Hyperdrive pool.
1818
/// @param _extraData The extra data that contains the pool and sweep targets.
1919
/// @param _salt The create2 salt used in the deployment.
20-
/// @return The address of the newly deployed ERC4626Target2 Instance.
20+
/// @return The address of the newly deployed ERC4626Target2 instance.
2121
function deploy(
2222
IHyperdrive.PoolConfig memory _config,
2323
bytes memory _extraData,

contracts/src/deployers/erc4626/ERC4626Target3Deployer.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ contract ERC4626Target3Deployer is IHyperdriveTargetDeployer {
1717
/// @param _config The configuration of the Hyperdrive pool.
1818
/// @param _extraData The extra data that contains the pool and sweep targets.
1919
/// @param _salt The create2 salt used in the deployment.
20-
/// @return The address of the newly deployed ERC4626Target3 Instance.
20+
/// @return The address of the newly deployed ERC4626Target3 instance.
2121
function deploy(
2222
IHyperdrive.PoolConfig memory _config,
2323
bytes memory _extraData,

contracts/src/deployers/erc4626/ERC4626Target4Deployer.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ contract ERC4626Target4Deployer is IHyperdriveTargetDeployer {
1717
/// @param _config The configuration of the Hyperdrive pool.
1818
/// @param _extraData The extra data that contains the pool and sweep targets.
1919
/// @param _salt The create2 salt used in the deployment.
20-
/// @return The address of the newly deployed ERC4626Target4 Instance.
20+
/// @return The address of the newly deployed ERC4626Target4 instance.
2121
function deploy(
2222
IHyperdrive.PoolConfig memory _config,
2323
bytes memory _extraData,

contracts/src/deployers/steth/StETHHyperdriveCoreDeployer.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ contract StETHHyperdriveCoreDeployer is IHyperdriveCoreDeployer {
3030
/// @param target3 The target3 address.
3131
/// @param target4 The target4 address.
3232
/// @param _salt The create2 salt used in the deployment.
33-
/// @return The address of the newly deployed StETHHyperdrive Instance.
33+
/// @return The address of the newly deployed StETHHyperdrive instance.
3434
function deploy(
3535
IHyperdrive.PoolConfig memory _config,
3636
bytes memory, // unused extra data

contracts/src/deployers/steth/StETHTarget0Deployer.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ contract StETHTarget0Deployer is IHyperdriveTargetDeployer {
2525
/// @notice Deploys a target0 instance with the given parameters.
2626
/// @param _config The configuration of the Hyperdrive pool.
2727
/// @param _salt The create2 salt used in the deployment.
28-
/// @return The address of the newly deployed StETHTarget0 Instance.
28+
/// @return The address of the newly deployed StETHTarget0 instance.
2929
function deploy(
3030
IHyperdrive.PoolConfig memory _config,
3131
bytes memory, // unused extra data

contracts/src/deployers/steth/StETHTarget1Deployer.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ contract StETHTarget1Deployer is IHyperdriveTargetDeployer {
2525
/// @notice Deploys a target1 instance with the given parameters.
2626
/// @param _config The configuration of the Hyperdrive pool.
2727
/// @param _salt The create2 salt used in the deployment.
28-
/// @return The address of the newly deployed StETHTarget1 Instance.
28+
/// @return The address of the newly deployed StETHTarget1 instance.
2929
function deploy(
3030
IHyperdrive.PoolConfig memory _config,
3131
bytes memory, // unused extra data

0 commit comments

Comments
 (0)