-
Notifications
You must be signed in to change notification settings - Fork 4
feat: resize sponsorship carrousel #579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for dev-bcn ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Few things I found:
|
icougil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my last comment
jonathanvila
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sí, yo lo veo tb así |
Bumps [@sentry/react](https://github.com/getsentry/sentry-javascript) from 8.37.1 to 8.38.0. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/develop/CHANGELOG.md) - [Commits](getsentry/sentry-javascript@8.37.1...8.38.0) --- updated-dependencies: - dependency-name: "@sentry/react" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@sentry/react](https://github.com/getsentry/sentry-javascript) from 8.38.0 to 8.41.0. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/develop/CHANGELOG.md) - [Commits](getsentry/sentry-javascript@8.38.0...8.41.0) --- updated-dependencies: - dependency-name: "@sentry/react" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [sass](https://github.com/sass/dart-sass) from 1.80.3 to 1.81.0. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md) - [Commits](sass/dart-sass@1.80.3...1.81.0) --- updated-dependencies: - dependency-name: sass dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Do you want to have a different sponsorship page per edition? What if the sponsor opens an old brochure and gets confused about the pricing and package options? |
|
I mean, the issue is that I was having a look at the preview via Netifly and the link was going to the "live" website (production), not to the "corresponding version" that was built. And ye, I think we should have different Sponsorship pages per edition (at least in each page things that are different: year, dates, etc) And the brochure will be always different... |
Bumps [prettier](https://github.com/prettier/prettier) from 3.3.3 to 3.4.2. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@3.3.3...3.4.2) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.9.0 to 22.10.2. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [nanoid](https://github.com/ai/nanoid) from 3.3.7 to 3.3.8. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](ai/nanoid@3.3.7...3.3.8) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [path-to-regexp](https://github.com/pillarjs/path-to-regexp) and [express](https://github.com/expressjs/express). These dependencies needed to be updated together. Updates `path-to-regexp` from 0.1.10 to 0.1.12 - [Release notes](https://github.com/pillarjs/path-to-regexp/releases) - [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md) - [Commits](pillarjs/path-to-regexp@v0.1.10...v0.1.12) Updates `express` from 4.21.1 to 4.21.2 - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/4.21.2/History.md) - [Commits](expressjs/express@4.21.1...4.21.2) --- updated-dependencies: - dependency-name: path-to-regexp dependency-type: indirect - dependency-name: express dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [react-router-dom](https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom) from 6.28.0 to 7.0.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/remix-run/react-router/releases">react-router-dom's releases</a>.</em></p> <blockquote> <h2>[email protected]</h2> <h3>Patch Changes</h3> <ul> <li>Updated dependencies <ul> <li>[email protected]</li> <li>[email protected]</li> </ul> </li> </ul> <h2>[email protected]</h2> <h3>Patch Changes</h3> <ul> <li>Updated dependencies <ul> <li>[email protected]</li> <li>[email protected]</li> </ul> </li> </ul> <h2>[email protected]</h2> <h3>Patch Changes</h3> <ul> <li>Updated dependencies <ul> <li>[email protected]</li> <li>[email protected]</li> </ul> </li> </ul> <h2>[email protected]</h2> <h3>Patch Changes</h3> <ul> <li>Updated dependencies <ul> <li>[email protected]</li> <li>[email protected]</li> </ul> </li> </ul> <h2>[email protected]</h2> <h3>Patch Changes</h3> <ul> <li>Updated dependencies <ul> <li>[email protected]</li> <li>[email protected]</li> </ul> </li> </ul> <h2>[email protected]</h2> <h3>Patch Changes</h3> <ul> <li>Updated dependencies <ul> <li><code>[email protected]</code></li> <li><code>[email protected]</code></li> </ul> </li> </ul> <h2>[email protected]</h2> <h3>Patch Changes</h3> <ul> <li>44bce3c6: Fix <code>react-router-dom</code> peer dependency version <ul> <li>[email protected]</li> <li>[email protected]</li> </ul> </li> </ul> <h2>[email protected]</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/remix-run/react-router/blob/main/packages/react-router-dom/CHANGELOG.md">react-router-dom's changelog</a>.</em></p> <blockquote> <h2>7.0.2</h2> <h3>Patch Changes</h3> <ul> <li>Updated dependencies: <ul> <li><code>[email protected]</code></li> </ul> </li> </ul> <h2>7.0.1</h2> <h3>Patch Changes</h3> <ul> <li>Updated dependencies: <ul> <li><code>[email protected]</code></li> </ul> </li> </ul> <h2>7.0.0</h2> <h3>Major Changes</h3> <ul> <li> <p>Remove the original <code>defer</code> implementation in favor of using raw promises via single fetch and <code>turbo-stream</code>. This removes these exports from React Router: (<a href="https://redirect.github.com/remix-run/react-router/pull/11744">#11744</a>)</p> <ul> <li><code>defer</code></li> <li><code>AbortedDeferredError</code></li> <li><code>type TypedDeferredData</code></li> <li><code>UNSAFE_DeferredData</code></li> <li><code>UNSAFE_DEFERRED_SYMBOL</code>,</li> </ul> </li> <li> <p>Use <code>createRemixRouter</code>/<code>RouterProvider</code> in <code>entry.client</code> instead of <code>RemixBrowser</code> (<a href="https://redirect.github.com/remix-run/react-router/pull/11469">#11469</a>)</p> </li> <li> <p>Remove single_fetch future flag. (<a href="https://redirect.github.com/remix-run/react-router/pull/11522">#11522</a>)</p> </li> <li> <p>Remove <code>future.v7_startTransition</code> flag (<a href="https://redirect.github.com/remix-run/react-router/pull/11696">#11696</a>)</p> </li> <li> <p>Remove <code>future.v7_normalizeFormMethod</code> future flag (<a href="https://redirect.github.com/remix-run/react-router/pull/11697">#11697</a>)</p> </li> <li> <p>Allow returning <code>undefined</code> from actions and loaders (<a href="https://redirect.github.com/remix-run/react-router/pull/11680">#11680</a>)</p> </li> <li> <p>update minimum node version to 18 (<a href="https://redirect.github.com/remix-run/react-router/pull/11690">#11690</a>)</p> </li> <li> <p>Remove <code>future.v7_prependBasename</code> from the ionternalized <code>@remix-run/router</code> package (<a href="https://redirect.github.com/remix-run/react-router/pull/11726">#11726</a>)</p> </li> <li> <p>Remove <code>future.v7_throwAbortReason</code> from internalized <code>@remix-run/router</code> package (<a href="https://redirect.github.com/remix-run/react-router/pull/11728">#11728</a>)</p> </li> <li> <p>Add <code>exports</code> field to all packages (<a href="https://redirect.github.com/remix-run/react-router/pull/11675">#11675</a>)</p> </li> <li> <p>node package no longer re-exports from react-router (<a href="https://redirect.github.com/remix-run/react-router/pull/11702">#11702</a>)</p> </li> <li> <p>updates the minimum React version to 18 (<a href="https://redirect.github.com/remix-run/react-router/pull/11689">#11689</a>)</p> </li> <li> <ul> <li>Remove the <code>future.v7_partialHydration</code> flag (<a href="https://redirect.github.com/remix-run/react-router/pull/11725">#11725</a>) <ul> <li>This also removes the <code><RouterProvider fallbackElement></code> prop</li> </ul> </li> </ul> </li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/remix-run/react-router/commit/a51b35d82b0f8cd35b6d0900c88c8d5686ebc8f1"><code>a51b35d</code></a> chore: Update version for release (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/12444">#12444</a>)</li> <li><a href="https://github.com/remix-run/react-router/commit/1007cc7f48b18ec5fe865fc52d1355238320a330"><code>1007cc7</code></a> chore: Update version for release (pre) (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/12442">#12442</a>)</li> <li><a href="https://github.com/remix-run/react-router/commit/47953dd5d762a048ed5bbeb0607a9b5098db2837"><code>47953dd</code></a> chore: format</li> <li><a href="https://github.com/remix-run/react-router/commit/202825ca687d15f17833dac34e7f59c401c0685e"><code>202825c</code></a> chore: Update version for release (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/12347">#12347</a>)</li> <li><a href="https://github.com/remix-run/react-router/commit/fd6c297658f01f48f1dd6ca9477342312d3fe2d0"><code>fd6c297</code></a> chore: format</li> <li><a href="https://github.com/remix-run/react-router/commit/d7dc44a9313be10227f93249de51efe30c771e44"><code>d7dc44a</code></a> Merge branch 'release-next' into dev</li> <li><a href="https://github.com/remix-run/react-router/commit/e8e3b004d94a949372e77ce97a543bff5bc6fb89"><code>e8e3b00</code></a> chore: Update version for release (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/12344">#12344</a>)</li> <li><a href="https://github.com/remix-run/react-router/commit/1499f3e43fa51370be698fc84a78150b13bd7535"><code>1499f3e</code></a> chore: Update version for release (pre) (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/12315">#12315</a>)</li> <li><a href="https://github.com/remix-run/react-router/commit/c8fd1384fa23d74d7dd72aad4915f20b00d7f35f"><code>c8fd138</code></a> docs: adjusted READMEs for the api docs generator</li> <li><a href="https://github.com/remix-run/react-router/commit/995bcbb7e480a5a481475825957b20c89f7f0201"><code>995bcbb</code></a> chore: Update version for release (pre) (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/12235">#12235</a>)</li> <li>Additional commits viewable in <a href="https://github.com/remix-run/react-router/commits/[email protected]/packages/react-router-dom">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Anyul Rivas <[email protected]>
…570) Bumps [@testing-library/jest-dom](https://github.com/testing-library/jest-dom) from 6.4.6 to 6.6.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/testing-library/jest-dom/releases"><code>@testing-library/jest-dom</code>'s releases</a>.</em></p> <blockquote> <h2>v6.6.3</h2> <h2><a href="https://github.com/testing-library/jest-dom/compare/v6.6.2...v6.6.3">6.6.3</a> (2024-10-31)</h2> <h3>Bug Fixes</h3> <ul> <li>add vitest import when extending vitest matchers (<a href="https://redirect.github.com/testing-library/jest-dom/issues/646">#646</a>) (<a href="https://github.com/testing-library/jest-dom/commit/5ba015651c7b10c154e5a4ae54f85df6010c5295">5ba0156</a>)</li> </ul> <h2>v6.6.2</h2> <h2><a href="https://github.com/testing-library/jest-dom/compare/v6.6.1...v6.6.2">6.6.2</a> (2024-10-17)</h2> <h3>Bug Fixes</h3> <ul> <li>remove recursive type reference in vitest types (<a href="https://redirect.github.com/testing-library/jest-dom/issues/636">#636</a>) (<a href="https://github.com/testing-library/jest-dom/commit/4468378fb4986018e0bacdebd02244decb9f0718">4468378</a>)</li> </ul> <h2>v6.6.1</h2> <h2><a href="https://github.com/testing-library/jest-dom/compare/v6.6.0...v6.6.1">6.6.1</a> (2024-10-16)</h2> <h3>Bug Fixes</h3> <ul> <li>fix lodash import in to-have-selection.js (<a href="https://redirect.github.com/testing-library/jest-dom/issues/642">#642</a>) (<a href="https://github.com/testing-library/jest-dom/commit/ced792e2f2773f16c249c6ce59fa8df968d28a20">ced792e</a>)</li> </ul> <h2>v6.6.0</h2> <h1><a href="https://github.com/testing-library/jest-dom/compare/v6.5.0...v6.6.0">6.6.0</a> (2024-10-16)</h1> <h3>Features</h3> <ul> <li>implement toHaveSelection (<a href="https://redirect.github.com/testing-library/jest-dom/issues/637">#637</a>) (<a href="https://github.com/testing-library/jest-dom/commit/9b148043d082a83f0ae5cdc03cdfc6a7c4573e6e">9b14804</a>)</li> </ul> <h2>v6.5.0</h2> <h1><a href="https://github.com/testing-library/jest-dom/compare/v6.4.8...v6.5.0">6.5.0</a> (2024-08-23)</h1> <h3>Features</h3> <ul> <li><strong>toHaveValue:</strong> Asserting aria-valuenow (<a href="https://redirect.github.com/testing-library/jest-dom/issues/479">#479</a>) (<a href="https://github.com/testing-library/jest-dom/commit/acbf416871cf43525d569703be0e50f00a294e9b">acbf416</a>)</li> </ul> <h2>v6.4.8</h2> <h2><a href="https://github.com/testing-library/jest-dom/compare/v6.4.7...v6.4.8">6.4.8</a> (2024-07-23)</h2> <h3>Bug Fixes</h3> <ul> <li>Drop peerDependencies from package.json (<a href="https://redirect.github.com/testing-library/jest-dom/issues/610">#610</a>) (<a href="https://github.com/testing-library/jest-dom/commit/faf534b6ffa20db8e3cad5824d8bc35bc2309965">faf534b</a>)</li> </ul> <h2>v6.4.7</h2> <h2><a href="https://github.com/testing-library/jest-dom/compare/v6.4.6...v6.4.7">6.4.7</a> (2024-07-22)</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/testing-library/jest-dom/commit/5ba015651c7b10c154e5a4ae54f85df6010c5295"><code>5ba0156</code></a> fix: add vitest import when extending vitest matchers (<a href="https://redirect.github.com/testing-library/jest-dom/issues/646">#646</a>)</li> <li><a href="https://github.com/testing-library/jest-dom/commit/4468378fb4986018e0bacdebd02244decb9f0718"><code>4468378</code></a> fix: remove recursive type reference in vitest types (<a href="https://redirect.github.com/testing-library/jest-dom/issues/636">#636</a>)</li> <li><a href="https://github.com/testing-library/jest-dom/commit/abba9613ac1968eebf96ad0ae9061cddf9afd777"><code>abba961</code></a> docs: add billyjanitsch as a contributor for bug (<a href="https://redirect.github.com/testing-library/jest-dom/issues/644">#644</a>)</li> <li><a href="https://github.com/testing-library/jest-dom/commit/9490615ce57f0315a4d189b7fa676692d0570ed7"><code>9490615</code></a> docs: add G-Rath as a contributor for code (<a href="https://redirect.github.com/testing-library/jest-dom/issues/643">#643</a>)</li> <li><a href="https://github.com/testing-library/jest-dom/commit/ced792e2f2773f16c249c6ce59fa8df968d28a20"><code>ced792e</code></a> fix: fix lodash import in to-have-selection.js (<a href="https://redirect.github.com/testing-library/jest-dom/issues/642">#642</a>)</li> <li><a href="https://github.com/testing-library/jest-dom/commit/9b148043d082a83f0ae5cdc03cdfc6a7c4573e6e"><code>9b14804</code></a> feat: implement toHaveSelection (<a href="https://redirect.github.com/testing-library/jest-dom/issues/637">#637</a>)</li> <li><a href="https://github.com/testing-library/jest-dom/commit/f5b0e943309c96c97b636342c3e3a1edbfbd5ffe"><code>f5b0e94</code></a> docs: add diegohaz as a contributor for ideas (<a href="https://redirect.github.com/testing-library/jest-dom/issues/640">#640</a>)</li> <li><a href="https://github.com/testing-library/jest-dom/commit/68e927e1c347036182a4278d00770c4a99bfd548"><code>68e927e</code></a> docs: add pwolaq as a contributor for code, and test (<a href="https://redirect.github.com/testing-library/jest-dom/issues/639">#639</a>)</li> <li><a href="https://github.com/testing-library/jest-dom/commit/04005dbb904ab061b7914f7c4ece7f84fd04b6f7"><code>04005db</code></a> docs: add silviuaavram as a contributor for code, and test (<a href="https://redirect.github.com/testing-library/jest-dom/issues/638">#638</a>)</li> <li><a href="https://github.com/testing-library/jest-dom/commit/4723de3664d129dfa97a877a4e0a9d171bc4c720"><code>4723de3</code></a> docs: add mibcadet as a contributor for doc (<a href="https://redirect.github.com/testing-library/jest-dom/issues/628">#628</a>)</li> <li>Additional commits viewable in <a href="https://github.com/testing-library/jest-dom/compare/v6.4.6...v6.6.3">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> > **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days. --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Anyul Rivas <[email protected]>
…/resize-carrousel # Conflicts: # src/views/Home/components/ActionButtons/ActionButtons.tsx
|
jonathanvila
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Rebase failed








solves #578