Skip to content

Commit 0932d4e

Browse files
committed
fix: download once during render / deploy --render
1 parent f07a3f3 commit 0932d4e

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

pkg/devspace/deploy/deployer/helm/render.go

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
package helm
22

33
import (
4-
devspacecontext "github.com/loft-sh/devspace/pkg/devspace/context"
54
"io"
5+
6+
devspacecontext "github.com/loft-sh/devspace/pkg/devspace/context"
7+
"github.com/pkg/errors"
68
)
79

810
// Render runs a `helm template`
@@ -12,6 +14,13 @@ func (d *DeployConfig) Render(ctx devspacecontext.Context, out io.Writer) error
1214
return err
1315
}
1416

17+
if d.DeploymentConfig.Helm.Chart.Source != nil {
18+
_, err := d.Helm.DownloadChart(ctx, d.DeploymentConfig.Helm)
19+
if err != nil {
20+
return errors.Wrap(err, "download chart")
21+
}
22+
}
23+
1524
_, err = d.internalDeploy(ctx, deployValues, out)
1625
return err
1726
}

pkg/devspace/helm/v3/client.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,11 +166,12 @@ func (c *client) Template(ctx devspacecontext.Context, releaseName, releaseNames
166166
// Chart settings
167167
chartName := ""
168168
if helmConfig.Chart.Source != nil {
169-
chartName, err = c.DownloadChart(ctx, helmConfig)
169+
chartName, err = dependencyutil.GetDependencyPath(ctx.WorkingDir(), helmConfig.Chart.Source)
170170
if err != nil {
171171
return "", err
172172
}
173173

174+
chartName = filepath.Dir(chartName)
174175
args = append(args, chartName)
175176
} else {
176177
var chartRepo string

0 commit comments

Comments
 (0)