Skip to content

Commit 5b36459

Browse files
authored
chore: updating tests and tooling for node 20 compatibility (#782)
1 parent 2ddecf6 commit 5b36459

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

73 files changed

+8661
-13581
lines changed

.github/workflows/e2e-tests.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
spec:
2020
- '0.16.1'
2121
node:
22-
- 16
22+
- 18
2323

2424
steps:
2525
- uses: actions/checkout@v2
@@ -28,9 +28,11 @@ jobs:
2828
with:
2929
node-version: ${{ matrix.node }}
3030

31-
- run: npm install -g npm@9
31+
- run: npm install -g npm
3232

3333
- run: npm install
34+
- run: pushd e2e/browser && npm install && popd
35+
- run: pushd e2e/node && npm install && popd
3436

3537
# build monorepo incl. each subpackage
3638
- run: npm run build --workspaces --if-present

.github/workflows/lint.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,13 @@ jobs:
1717
spec:
1818
- release-0.16 # https://github.com/dfinity-lab/ic-ref/tree/release-0.16
1919
node:
20-
- 14
20+
- 20
2121
steps:
2222
- uses: actions/checkout@v2
2323
- name: Use Node.js ${{ matrix.node }}
2424
uses: actions/setup-node@v1
2525
with:
2626
node-version: ${{ matrix.node }}
27-
- run: npm install -g npm@9
27+
- run: npm install -g npm
2828
- run: npm install
2929
- run: npm run lint --workspaces --if-present

.github/workflows/mitm.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
spec:
2121
- '0.16.1'
2222
node:
23-
- 16
23+
- 20
2424

2525
steps:
2626
- uses: actions/checkout@v2
@@ -29,7 +29,7 @@ jobs:
2929
with:
3030
node-version: ${{ matrix.node }}
3131

32-
- run: npm install -g npm@9
32+
- run: npm install -g npm
3333

3434
- run: npm install
3535

.github/workflows/prettier.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,15 @@ jobs:
1717
spec:
1818
- release-0.16 # https://github.com/dfinity-lab/ic-ref/tree/release-0.16
1919
node:
20-
- 14
20+
- 20
2121
steps:
2222
- uses: actions/checkout@v2
2323
- name: Use Node.js ${{ matrix.node }}
2424
uses: actions/setup-node@v1
2525
with:
2626
node-version: ${{ matrix.node }}
27-
- run: npm install -g npm@9
28-
- run: npm install prettier pretty-quick
27+
- run: npm install -g npm
28+
- run: npm ci
2929
- run: npm run prettier:check
3030

3131
aggregate:

.github/workflows/size-limit.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ jobs:
77
CI_JOB_NUMBER: 1
88
steps:
99
- uses: actions/checkout@v1
10-
- run: npm install -g npm@9
10+
- run: npm install -g npm
1111
# - run: npm run size-limit --workspaces --if-present
1212

1313
# commented out until the job can be configured

.github/workflows/unit-tests.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ jobs:
1919
spec:
2020
- '0.16.1'
2121
node:
22-
- 14
23-
- 16
22+
- 18
23+
- 20
2424

2525
steps:
2626
- uses: actions/checkout@v2
@@ -29,9 +29,9 @@ jobs:
2929
with:
3030
node-version: ${{ matrix.node }}
3131

32-
- run: npm install -g npm@9
32+
- run: npm install -g npm
3333

34-
- run: npm ci
34+
- run: npm install
3535

3636
# build monorepo incl. each subpackage
3737
- run: npm run build --workspaces --if-present

.husky/.gitignore

Lines changed: 0 additions & 1 deletion
This file was deleted.

.husky/pre-commit

Lines changed: 0 additions & 4 deletions
This file was deleted.

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
v18.16
1+
v20.9.0

demos/sample-javascript/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@
2424
"stream-browserify": "^3.0.0",
2525
"ts-node": "^10.8.2",
2626
"util": "^0.12.3",
27+
"webpack": "^5.76.0",
2728
"webpack-cli": "^4.5.0",
28-
"webpack-dev-server": "^4.0.0-beta.0",
29-
"webpack": "^5.76.0"
29+
"webpack-dev-server": "^4.0.0-beta.0"
3030
}
3131
}

0 commit comments

Comments
 (0)