-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Open
Description
Describe the bug
We update patches automatically in our projects, since we expect them to be backwards compatible and not require us to do manual changes.
However, #2247 was released as a patch, even though it requires users of the previous usePDF
hook manual changes that are not mentioned anywhere.
To Reproduce
Previous usage (based on test in #2247):
# const [instance, updateInstance] = usePDF(
- { document: doc }
# );
# useEffect(
- updateInstance,
# [doc]
# );
New usage:
# const [instance, updateInstance] = usePDF(
+
# );
# useEffect(
+ () => updateInstance(doc),
# [doc]
# );
Expected behavior
Backwards compatibility on a patch
or release as a minor
or even major
version, which mentions required changes for affected users.
Desktop (please complete the following information):
- OS: Linux
- Browser firefox, chromium
- React-pdf version v3.1.12
0xCAFEADD1C7, joe-kimlinger and MohamedRahoui
Metadata
Metadata
Assignees
Labels
No labels