Fixup with some renames.

Author: nedtwigg

tests/corpus-fixture.ts

@@ -40,8 +40,27 @@ export const describe = baseDescribe
 // Re-export expect from vitest
 export { expect }
 
+// Fluent interface for any corpus type (HAR or HTML)
+export function withCorpus(corpusKey: keyof typeof CORPUS) {
+  return {
+    it: (name: string, fn: () => void | Promise<void>) => {
+      return baseTest(`${String(corpusKey)}:${name}`, async () => {
+        // Setup DOM for any corpus type (delegates to HAR or HTML based on type)
+        await setupDOM(corpusKey)
+
+        try {
+          return await fn()
+        } finally {
+          // Cleanup after test
+          cleanupDOM()
+        }
+      })
+    },
+  }
+}
+
 // Helper function for detection tests
-export function getDetectionResults() {
+export function detectedSpots() {
   const enhancers = new EnhancerRegistry()
   const textareas = document.querySelectorAll('textarea')
   const location: StrippedLocation = {
@@ -61,7 +80,7 @@ export function getDetectionResults() {
 }
 
 // Helper function for UI tests
-export function getUIResults() {
+export function tableUI() {
   const enhancers = new EnhancerRegistry()
   const textareas = document.querySelectorAll('textarea')
   const location: StrippedLocation = {
@@ -88,22 +107,3 @@ export function getUIResults() {
   }
   return uiResults
 }
-
-// Fluent interface for any corpus type (HAR or HTML)
-export function withCorpus(corpusKey: keyof typeof CORPUS) {
-  return {
-    it: (name: string, fn: () => void | Promise<void>) => {
-      return baseTest(`${String(corpusKey)}:${name}`, async () => {
-        // Setup DOM for any corpus type (delegates to HAR or HTML based on type)
-        await setupDOM(corpusKey)
-
-        try {
-          return await fn()
-        } finally {
-          // Cleanup after test
-          cleanupDOM()
-        }
-      })
-    },
-  }
-}

tests/lib/enhancers/gh_detection.test.ts

@@ -1,13 +1,15 @@
 import { CORPUS } from '../../corpus/_corpus-index'
-import { describe, expect, getDetectionResults, withCorpus } from '../../corpus-fixture'
+import { describe, detectedSpots, expect, withCorpus } from '../../corpus-fixture'
 
 // Get all corpus entries that start with 'gh_'
-const githubCorpusEntries = Object.keys(CORPUS).filter((key) => key.startsWith('gh_'))
+const githubCorpusEntries = (Object.keys(CORPUS) as Array<keyof typeof CORPUS>).filter((key) =>
+  key.startsWith('gh_'),
+)
 
 describe('github detection', () => {
   for (const corpusKey of githubCorpusEntries) {
-    withCorpus(corpusKey as keyof typeof CORPUS).it('should detect correct spots', async () => {
-      expect(getDetectionResults()).toMatchSnapshot()
+    withCorpus(corpusKey).it('should detect correct spots', async () => {
+      expect(detectedSpots()).toMatchSnapshot()
     })
   }
 })

tests/lib/enhancers/gh_ui.test.ts

@@ -1,18 +1,18 @@
-import { describe, expect, getUIResults, withCorpus } from '../../corpus-fixture'
+import { describe, expect, tableUI, withCorpus } from '../../corpus-fixture'
 
 expect
 
 import { CORPUS } from '../../corpus/_corpus-index'
 
 // Get all corpus entries that start with 'gh_'
-const githubCorpusEntries = Object.keys(CORPUS).filter((key) => key.startsWith('gh_'))
+const githubCorpusEntries = (Object.keys(CORPUS) as Array<keyof typeof CORPUS>).filter((key) =>
+  key.startsWith('gh_'),
+)
 
 describe('github ui', () => {
   for (const corpusKey of githubCorpusEntries) {
-    withCorpus(
-      corpusKey as keyof typeof CORPUS,
-    ).it('should render correct UI elements', async () => {
-      expect(getUIResults()).toMatchSnapshot()
+    withCorpus(corpusKey).it('should render correct UI elements', async () => {
+      expect(tableUI()).toMatchSnapshot()
     })
   }
 })