Skip to content

Don't use user-facing text to identify user elements #43

@nedtwigg

Description

@nedtwigg

const writeTab = writePreviewTabs.find((button) => button.textContent.includes('Write'))
const previewTab = writePreviewTabs.find((button) => button.textContent.includes('Preview'))

  • Finding classes or IDs to identify these will be fragile to engineering changes, but resilient to locale
  • The approach we are using now only works for english users

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions