chore: move PRESYNC_NAMESPACES into central constants file (#767)

This change should have no impact.

The `PRESYNC_NAMESPACES` array is pretty central, but was stuffed away
in `sync/peer-sync-controller.js`; that doesn't quite feel like where it
belongs.

Now it's in a more central spot: `constants.js`.

I think this is useful on its own, but it should make a future change
easier.

Author: EvanHahn

src/constants.js

@@ -1,3 +1,5 @@
+/** @import { Namespace } from './types.js' */
+
 // WARNING: Changing these will break things for existing apps, since namespaces
 // are used for key derivation
 export const NAMESPACES = /** @type {const} */ ([
@@ -8,6 +10,9 @@ export const NAMESPACES = /** @type {const} */ ([
   'blob',
 ])
 
+/** @type {ReadonlyArray<Namespace>} */
+export const PRESYNC_NAMESPACES = ['auth', 'config', 'blobIndex']
+
 export const NAMESPACE_SCHEMAS = /** @type {const} */ ({
   data: ['observation', 'track'],
   config: [

src/sync/peer-sync-controller.js

@@ -1,5 +1,5 @@
 import mapObject from 'map-obj'
-import { NAMESPACES } from '../constants.js'
+import { NAMESPACES, PRESYNC_NAMESPACES } from '../constants.js'
 import { Logger } from '../logger.js'
 import { ExhaustivenessError, createMap } from '../utils.js'
 /** @import { CoreRecord } from '../core-manager/index.js' */
@@ -11,9 +11,6 @@ import { ExhaustivenessError, createMap } from '../utils.js'
  * @typedef {Role['sync'][Namespace] | 'unknown'} SyncCapability
  */
 
-/** @type {Namespace[]} */
-export const PRESYNC_NAMESPACES = ['auth', 'config', 'blobIndex']
-
 export class PeerSyncController {
   #replicatingCores = new Set()
   /** @type {Set<Namespace>} */

src/sync/sync-api.js

@@ -1,11 +1,8 @@
 import { TypedEmitter } from 'tiny-typed-emitter'
 import { SyncState } from './sync-state.js'
-import {
-  PeerSyncController,
-  PRESYNC_NAMESPACES,
-} from './peer-sync-controller.js'
+import { PeerSyncController } from './peer-sync-controller.js'
 import { Logger } from '../logger.js'
-import { NAMESPACES } from '../constants.js'
+import { NAMESPACES, PRESYNC_NAMESPACES } from '../constants.js'
 import { ExhaustivenessError, assert, keyToId } from '../utils.js'
 
 export const kHandleDiscoveryKey = Symbol('handle discovery key')

test-e2e/sync.js

@@ -19,9 +19,8 @@ import {
 } from './utils.js'
 import { kCoreManager } from '../src/mapeo-project.js'
 import { getKeys } from '../tests/helpers/core-manager.js'
-import { NAMESPACES } from '../src/constants.js'
+import { NAMESPACES, PRESYNC_NAMESPACES } from '../src/constants.js'
 import { FastifyController } from '../src/fastify-controller.js'
-import { PRESYNC_NAMESPACES } from '../src/sync/peer-sync-controller.js'
 import { generate } from '@mapeo/mock-data'
 import { valueOf } from '../src/utils.js'
 import pTimeout from 'p-timeout'