feat: Add setting for default archive device value (#1102)

Co-authored-by: Mauve Signweaver <[email protected]>

Author: RangerMauve

src/mapeo-manager.js

@@ -90,6 +90,8 @@ export const DEFAULT_FALLBACK_MAP_FILE_PATH = require.resolve(
 export const DEFAULT_ONLINE_STYLE_URL =
   'https://demotiles.maplibre.org/style.json'
 
+export const DEFAULT_IS_ARCHIVE_DEVICE = true
+
 /**
  * @typedef {Omit<import('./local-peers.js').PeerInfo, 'protomux'>} PublicPeerInfo
  */
@@ -123,6 +125,7 @@ export class MapeoManager extends TypedEmitter {
   #l
   #defaultConfigPath
   #makeWebsocket
+  #defaultIsArchiveDevice
 
   /**
    * @param {Object} opts
@@ -136,6 +139,7 @@ export class MapeoManager extends TypedEmitter {
    * @param {string} [opts.customMapPath] File path to a locally stored Styled Map Package (SMP).
    * @param {string} [opts.fallbackMapPath] File path to a locally stored Styled Map Package (SMP)
    * @param {string} [opts.defaultOnlineStyleUrl] URL for an online-hosted StyleJSON asset.
+   * @param {boolean} [opts.defaultIsArchiveDevice] Whether the node is an archive device by default
    * @param {(url: string) => WebSocket} [opts.makeWebsocket]
    */
   constructor({
@@ -149,12 +153,14 @@ export class MapeoManager extends TypedEmitter {
     customMapPath,
     fallbackMapPath = DEFAULT_FALLBACK_MAP_FILE_PATH,
     defaultOnlineStyleUrl = DEFAULT_ONLINE_STYLE_URL,
+    defaultIsArchiveDevice = DEFAULT_IS_ARCHIVE_DEVICE,
     makeWebsocket = (url) => new WebSocket(url),
   }) {
     super()
     this.#keyManager = new KeyManager(rootKey)
     this.#deviceId = getDeviceId(this.#keyManager)
     this.#defaultConfigPath = defaultConfigPath
+    this.#defaultIsArchiveDevice = defaultIsArchiveDevice
     this.#makeWebsocket = makeWebsocket
     const logger = (this.#loggerBase = new Logger({ deviceId: this.#deviceId }))
     this.#l = Logger.create('manager', logger)
@@ -882,7 +888,7 @@ export class MapeoManager extends TypedEmitter {
     if (typeof row?.isArchiveDevice === 'boolean') {
       return row.isArchiveDevice
     } else {
-      return true
+      return this.#defaultIsArchiveDevice
     }
   }
 

test-e2e/manager-archive-device.js

@@ -41,6 +41,26 @@ test('Set & Get isArchiveDevice', async (t) => {
   )
 })
 
+test('Default isArchiveDevice', async (t) => {
+  const manager = createManager('seed', t, {
+    defaultIsArchiveDevice: false,
+  })
+  assert.strictEqual(
+    manager.getIsArchiveDevice(),
+    false,
+    'isArchiveDevice is false initially'
+  )
+
+  // Ensure at least one project exists (tests internal setting on project)
+  const projectId = await manager.createProject()
+  const project = await manager.getProject(projectId)
+  assert.strictEqual(
+    project[kIsArchiveDevice],
+    false,
+    'Project isArchiveDevice is false initially'
+  )
+})
+
 test('isArchiveDevice persists', async (t) => {
   const custodian = new ManagerCustodian(t)