chore: Add more logs for invites (#1064)

Co-authored-by: Mauve Signweaver <[email protected]>

Author: RangerMauve

src/invite/invite-api.js

@@ -281,35 +281,43 @@ export class InviteApi extends TypedEmitter {
    * @returns {Promise<string>}
    */
   async accept({ inviteId: inviteIdString }) {
-    const inviteId = Buffer.from(inviteIdString, 'hex')
-
-    const invite = this.#invites.get(inviteId)
-    assert(!!invite, new NotFoundError(`Cannot find invite ${inviteIdString}`))
-    assertCanSend(invite.actor, { type: 'ACCEPT_INVITE' })
+    try {
+      const inviteId = Buffer.from(inviteIdString, 'hex')
 
-    this.#l.log('Accepting invite %h', inviteId)
-    invite.actor.send({ type: 'ACCEPT_INVITE' })
-
-    for (const { value, actor } of this.#invites.values()) {
-      if (value.inviteId.equals(inviteId)) continue
-      const inviteIsForSameProject = value.projectInviteId.equals(
-        invite.value.projectInviteId
+      const invite = this.#invites.get(inviteId)
+      assert(
+        !!invite,
+        new NotFoundError(`Cannot find invite ${inviteIdString}`)
       )
-      if (inviteIsForSameProject) {
-        actor.send({ type: 'ALREADY_IN_PROJECT' })
+      assertCanSend(invite.actor, { type: 'ACCEPT_INVITE' })
+
+      this.#l.log('Accepting invite %h', inviteId)
+      invite.actor.send({ type: 'ACCEPT_INVITE' })
+
+      for (const { value, actor } of this.#invites.values()) {
+        if (value.inviteId.equals(inviteId)) continue
+        const inviteIsForSameProject = value.projectInviteId.equals(
+          invite.value.projectInviteId
+        )
+        if (inviteIsForSameProject) {
+          actor.send({ type: 'ALREADY_IN_PROJECT' })
+        }
       }
-    }
 
-    const { projectPublicId } = await toPromise(invite.actor)
+      const { projectPublicId } = await toPromise(invite.actor)
 
-    if (!projectPublicId) {
-      const { context, value } = invite.actor.getSnapshot()
-      throw value === 'respondedAlready'
-        ? new AlreadyJoinedError('Already joining or in project')
-        : context.error || new Error('Unknown error')
-    }
+      if (!projectPublicId) {
+        const { context, value } = invite.actor.getSnapshot()
+        throw value === 'respondedAlready'
+          ? new AlreadyJoinedError('Already joining or in project')
+          : context.error || new Error('Unknown error')
+      }
 
-    return projectPublicId
+      return projectPublicId
+    } catch (err) {
+      this.#l.log('ERROR: Unable to accept invite', err)
+      throw err
+    }
   }
 
   /**

src/member-api.js

@@ -235,6 +235,7 @@ export class MemberApi extends TypedEmitter {
       }
     } catch (err) {
       if (err instanceof Error && err.name === 'RPCDisconnectBeforeAckError') {
+        this.#l.log('ERROR: Disconnect before ack', err)
         throw new InviteAbortedError()
       }
       throw err
@@ -283,8 +284,10 @@ export class MemberApi extends TypedEmitter {
       return await responsePromise
     } catch (err) {
       if (err instanceof Error && err.name === 'AbortError') {
+        this.#l.log('ERROR: Timed out sending invite', err)
         throw new InviteAbortedError()
       } else {
+        this.#l.log('ERROR: Unexpected error during invite send', err)
         throw err
       }
     } finally {