Skip to content

Wire up key validation builtin into the compiler #22428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
carlpulley-da wants to merge 5 commits into
base: cjp/issue-29484-builtin
Choose a base branch
from
Open

Wire up key validation builtin into the compiler #22428

carlpulley-da wants to merge 5 commits into from

Conversation

@carlpulley-da
Copy link
Contributor

@carlpulley-da carlpulley-da commented Nov 26, 2025 •
edited
Loading

  • add SECP256K1_VALIDATE_KEY primitive to compiler and wire through rest of compiler stack

Notes:

future PR will:

  • add in a compiler feature flag for primitive usage
  • enable use of the SECP256K1_VALIDATE_KEY LF primitive in Daml surface language
  • provide daml-script testing of the SECP256K1_VALIDATE_KEY primitive
  • library support for using secp2561 Daml functions with key validation

@carlpulley-da carlpulley-da self-assigned this Nov 26, 2025
@carlpulley-da carlpulley-da marked this pull request as ready for review November 26, 2025 13:47
@carlpulley-da carlpulley-da requested a review from a team November 26, 2025 13:47
@carlpulley-da carlpulley-da changed the base branch from main to cjp/issue-29484-builtin November 26, 2025 13:47
carlpulley-da
carlpulley-da commented Nov 26, 2025
View reviewed changes
sdk/daml-lf/archive/src/protobuf/com/digitalasset/daml/lf/archive/daml_lf2.proto

TYPE_REP_TYCON_NAME = 3011; // *Available in versions >= 2.dev*

SECP256K1_VALIDATE_KEY = 4001; // *Available in versions >= 2.dev*
Copy link
Contributor Author

@carlpulley-da carlpulley-da Nov 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the moment, SECP256K1_VALIDATE_KEY is dev only. A follow on PR will add damlc feature flags for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@remyhaemmerle-da remyhaemmerle-da remyhaemmerle-da approved these changes

Assignees

@carlpulley-da carlpulley-da

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@carlpulley-da @remyhaemmerle-da