Apply suggestions from code review.

Co-authored-by: Dave Longley <[email protected]>

Author: jameseaster

lib/BedrockKeystoreConfigStorage.js

@@ -36,18 +36,18 @@ export class BedrockKeystoreConfigStorage extends KeystoreConfigStorage {
 
   async getAll({
     controller, req, query = {}, options = {},
-    explain = false, returnRecord = false
+    returnRecord = false
   } = {}) {
     const records = await keystores.find({
-      controller, query, options, explain
+      controller, query, options
     });
     const keystoreConfigs = records.map(r => r.config);
     // skip request checks if specifically requested
     if(req === false) {
       return returnRecord ? records : keystoreConfigs;
     }
     // verify that request is from an IP that is allowed to access the config
-    for(let i = 0; i < keystoreConfigs.length; i++) {
+    for(let i = 0; i < keystoreConfigs.length; ++i) {
       const keystoreConfig = keystoreConfigs[i];
       const {verified} = helpers.verifyRequestIp({keystoreConfig, req});
       if(!verified) {

lib/http.js

@@ -76,7 +76,7 @@ bedrock.events.on('bedrock-express.configure.routes', app => {
     }),
     asyncHandler(async (req, res) => {
       const controller = req.query.controller;
-      const options = {projection: {_id: 0, config: 1}};
+      const options = {projection: {_id: 0, config: 1}, limit: 100};
       const results = await storage.getAll({controller, req, options});
       res.json({results});
     }));