Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, I love this plugin ❤️.
However we are using
tensorflowand related packages which are living in the dark ages ofprotobuf==3.19.x. I also noticed that this package doesn't useprotobuf, but rather its upstream packages do, which begs the question, is it necessary to pin a specific protobuf version in this package?I have also tested the newer version of
opentelemetry-*==1.14.0and the unit tests are passing. However its entirely possible there are some network features that need testing and may break compatibility.I can change the PR to remove the protobuf dependency entirely, or not update opentelemetry if thats an issue.
Im mostly here for the awesome @ decorator!