cagent repl blows up when shell tries to read from stdin

[nicks]

Describe the bug

My agent has toolsets

    toolsets:
      - type: shell
      - type: filesystem

The agent tried to run git clone.

I was running it in a sandbox with no git credentials so git prompted it for credentials.

Unfortunately, doing I/O on stdin blew up the cagent repl. The only option is to ctrl-c to exit the session

Version affected
v1.7.3

Screenshots

OS and Terminal type

alacritty / linux

[dgageot]

I've tried with cat and read but it fails fast, with a clear explanation.
git must be a bit special.

[dgageot]

Yeah, git clone http://github.com/dcker/dcker does repro

[dgageot]

Turns out git is good at controlling the terminal it was launched from...
Even though we override its stdin/out/err, it'll print to the terminal and read from it through git-remote-http.
To disable that, we have to shel out with

&syscall.SysProcAttr{
Setsid:  true,
}

But unfortunately, that's not possible, because we already require this:

&syscall.SysProcAttr{
Setpgid: true,
}

I'm not sure why but I'll investigate.

[dgageot]

I'm going to close this one because the issue is more on git side that really really wants to mess with the terminal