test BunJS support #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
force-pushed
the
bunjs
branch
10 times, most recently
from
57e797f to
9335c92
Compare
wmluke
requested changes
Oct 31, 2025
Contributor
wmluke
left a comment
wmluke
left a comment
There was a problem hiding this comment.
Looks good. Just some minor changes.
test/concurrency.test.ts
Outdated
| const totalTime = Date.now() - startTime; | ||
|
|
||
| // Verify all requests completed successfully | ||
| assert.ok(results[0]); // systemPing result |
Contributor
There was a problem hiding this comment.
I'm a bit concerned about replacing isNotNull with ok. The former is strictly checking that the value !== null. The latter is checking that its truthy, which is significantly wider assertion. Maybe try assert. notStrictEqual(results[0], null)
test/util.test.ts
Outdated
| test('should return undefined for null', () => { | ||
| const result = getErrorMessage(null); | ||
| assert.isUndefined(result); | ||
| assert.equal(result, undefined); |
Contributor
There was a problem hiding this comment.
I recommend assert.strictEqual b/c it uses === while assert.equal uses ==.
Signed-off-by: Nicolas De Loof <[email protected]>
wmluke
approved these changes
Nov 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR make test use node:test vs vitest, as the latter isn't compatible with bunJS and as such prevent us to work toward support for this runtime