Add package.xml to cmake package #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
dorian3d
approved these changes
May 6, 2020
package.xml
Outdated
| Enhanced hierarchical bag-of-word library for C++ | ||
| </description> | ||
| <maintainer email="[email protected]">Dorian Gálvez-López</maintainer> | ||
| <license>BSD</license> |
Owner
There was a problem hiding this comment.
Although based in BSD, the DBoW2 license adds an extra clause that allows me to be notified when people use the library. Could you change this to something like BSD + notification?
Contributor
Author
There was a problem hiding this comment.
I've incorporated the feedback, but you may want to consider using a standard open source licence to better allow for redistribution, as many community packaging channels are now automated and have no means of submitting notice.
for extra notification clause
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply adds a package.xml used for build tools like catkin or colcon, allowing for the essential build dependencies to be readily identified and when scheduling build order from dependency graphs.