-
Notifications
You must be signed in to change notification settings - Fork 402
Update ISystemOperations.cs to give proper warning for MonitorEventsAsync #599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Changed Obselete warning to read out the correct shape of the MonitorEventsAsync Task.
HofmeisterAn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I guess it should be IProgress<Message> too.
Co-authored-by: Andre Hofmeister <[email protected]>
|
@galvesribeiro Can we merge this, please? |
|
The build is failing. Can you fix this first? |
I do not think the change and the failing build belongs together. The change only updates the description of an already obsolete method. There is another issue. |
|
@HofmeisterAn from my experience with tests running on CI/CD pipeline, from time to time docker fails. |
Yep, I agree. Although, an empty commit is not necessary IMO. The PR does not change anything expect documentation. Some tests are flaky, I noticed that too. I can take a look at that one. |
|
@MagnusMat my suggestion about pushing a new empty commit to trigger the CI/CD pipeline was meant for you, I made a mistake when tagging the author |
Changed Obselete warning to read out the correct shape of the MonitorEventsAsync Task.