Upgrade to .NET 10, update version to 1.4, and enhance batch file creation logic with improved error handling, write access verification, and filename sanitization.

Author: drpetersonfernandes

CreateBatchFilesForPS3Games/CreateBatchFilesForPS3Games.csproj

@@ -2,20 +2,21 @@
 
   <PropertyGroup>
     <OutputType>WinExe</OutputType>
-    <TargetFramework>net9.0-windows</TargetFramework>
+    <TargetFramework>net10.0-windows</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
     <ApplicationIcon>icon\icon.ico</ApplicationIcon>
     <UseWPF>true</UseWPF>
     <SupportedOSPlatformVersion>7.0</SupportedOSPlatformVersion>
-    <AssemblyVersion>1.3</AssemblyVersion>
-    <FileVersion>1.3</FileVersion>
+    <AssemblyVersion>1.4</AssemblyVersion>
+    <FileVersion>1.4</FileVersion>
     <RootNamespace>CreateBatchFilesForPS3Games</RootNamespace>
     <IsPackable>false</IsPackable>
-    <LangVersion>13</LangVersion>
+    <LangVersion>14</LangVersion>
     <NeutralLanguage>en-US</NeutralLanguage>
     <DebugType>embedded</DebugType>
     <DebugSymbols>true</DebugSymbols>
+    <EnableWindowsLongPath>true</EnableWindowsLongPath>
   </PropertyGroup>
 
   <ItemGroup>

CreateBatchFilesForPS3Games/MainWindow.xaml.cs

@@ -87,6 +87,16 @@ private async void CreateBatchFilesButton_Click(object sender, RoutedEventArgs e
                 return;
             }
 
+            if (!VerifyWriteAccess(outputFolder))
+            {
+                ShowError("Cannot write to the selected folder. Please try these solutions:\n\n" +
+                          "1. Run the application as Administrator\n" +
+                          "2. Choose a different output folder (e.g., your Desktop or Documents)\n" +
+                          "3. Check the folder security permissions in Windows Explorer");
+                UpdateStatusBarMessage("Error: Insufficient folder permissions.");
+                return;
+            }
+
             CreateBatchFilesButton.IsEnabled = false;
             UpdateStatusBarMessage("Processing... please wait.");
 
@@ -201,18 +211,55 @@ private enum GameType
 
             try
             {
-                await using var sw = new StreamWriter(batchFilePath);
-                var rpcs3Directory = Path.GetDirectoryName(rpcs3ExePath);
-                await sw.WriteLineAsync("@echo off");
-                await sw.WriteLineAsync($"cd /d \"{rpcs3Directory}\"");
-                await sw.WriteLineAsync($"start \"\" \"{rpcs3ExePath}\" --no-gui \"{ebootPath}\"");
-                LogMessage($"Batch file created: {batchFilePath}");
+                // Check and handle existing files
+                if (File.Exists(batchFilePath))
+                {
+                    try
+                    {
+                        // Remove the read-only attribute if present
+                        var fileInfo = new FileInfo(batchFilePath);
+                        if (fileInfo.IsReadOnly)
+                        {
+                            fileInfo.IsReadOnly = false;
+                        }
+
+                        File.Delete(batchFilePath);
+                    }
+                    catch (Exception deleteEx)
+                    {
+                        LogMessage($"⚠️ Skipping '{batchFileName}.bat': Cannot overwrite existing file - {deleteEx.Message}");
+                        continue; // Skip this file and continue with others
+                    }
+                }
+
+                // Create the batch file with explicit sharing permissions
+                await using (var fs = new FileStream(batchFilePath, FileMode.Create, FileAccess.Write, FileShare.None))
+                await using (var sw = new StreamWriter(fs))
+                {
+                    var rpcs3Directory = Path.GetDirectoryName(rpcs3ExePath);
+                    await sw.WriteLineAsync("@echo off");
+                    await sw.WriteLineAsync($"cd /d \"{rpcs3Directory}\"");
+                    await sw.WriteLineAsync($"start \"\" \"{rpcs3ExePath}\" --no-gui \"{ebootPath}\"");
+                }
+
+                LogMessage($"✓ Batch file created: {batchFilePath}");
                 filesCreated++;
             }
+            catch (UnauthorizedAccessException ex)
+            {
+                LogMessage($"❌ Access denied for '{batchFileName}.bat': {ex.Message}");
+                LogMessage("   → Try running the application as Administrator");
+                // Don't report permission issues as bugs - they're user environment issues
+            }
+            catch (IOException ex)
+            {
+                LogMessage($"❌ IO error creating '{batchFileName}.bat': {ex.Message}");
+                await ReportBugAsync($"IO error creating batch file: {batchFileName}", ex);
+            }
             catch (Exception ex)
             {
-                LogMessage($"Failed to create batch file for {Path.GetFileName(subdirectory)}: {ex.Message}");
-                await ReportBugAsync($"Failed to create batch file for {batchFileName}", ex);
+                LogMessage($"❌ Failed to create batch file for {Path.GetFileName(subdirectory)}: {ex.Message}");
+                await ReportBugAsync($"Unexpected error creating batch file: {batchFileName}", ex);
             }
         }
 
@@ -267,12 +314,34 @@ private string SanitizeFileName(string filename)
 
         // Clean up whitespace.
         filename = filename.Trim();
+
         // Replace multiple spaces with a single space.
         while (filename.Contains("  ", StringComparison.Ordinal))
         {
             filename = filename.Replace("  ", " ", StringComparison.Ordinal);
         }
 
+        // Remove trailing spaces and dots (invalid in Windows)
+        filename = filename.TrimEnd(' ', '.');
+
+        // Handle Windows reserved device names
+        var reservedNames = new[]
+        {
+            "CON", "PRN", "AUX", "NUL", "COM1", "COM2", "COM3", "COM4", "COM5",
+            "COM6", "COM7", "COM8", "COM9", "LPT1", "LPT2", "LPT3", "LPT4",
+            "LPT5", "LPT6", "LPT7", "LPT8", "LPT9"
+        };
+        if (reservedNames.Contains(filename.ToUpperInvariant()))
+        {
+            filename = $"_{filename}_";
+        }
+
+        // Ensure the filename is not empty after sanitization
+        if (string.IsNullOrWhiteSpace(filename))
+        {
+            filename = "UntitledGame";
+        }
+
         // Remove any invalid file name characters.
         var invalidChars = Path.GetInvalidFileNameChars();
         return string.Concat(filename.Split(invalidChars));
@@ -399,6 +468,11 @@ private async Task ReportBugAsync(string message, Exception? exception = null)
     {
         if (App.BugReportService == null) return;
 
+        if (exception is UnauthorizedAccessException)
+        {
+            return;
+        }
+
         try
         {
             var fullReport = new StringBuilder();
@@ -464,4 +538,21 @@ private void AboutMenuItem_Click(object sender, RoutedEventArgs e)
             _ = ReportBugAsync("Error opening About window", ex);
         }
     }
+
+    private bool VerifyWriteAccess(string folderPath)
+    {
+        try
+        {
+            // Test write permissions by creating and deleting a temporary file
+            var testFile = Path.Combine(folderPath, $".temp_test_{Guid.NewGuid().ToString("N")[..8]}.tmp");
+            File.WriteAllText(testFile, string.Empty);
+            File.Delete(testFile);
+            return true;
+        }
+        catch (Exception ex)
+        {
+            LogMessage($"Write permission check failed for '{folderPath}': {ex.Message}");
+            return false;
+        }
+    }
 }

global.json

@@ -1,6 +1,6 @@
 {
   "sdk": {
-    "version": "9.0.0",
+    "version": "10.0.0",
     "rollForward": "latestMajor",
     "allowPrerelease": false
   }