Set registry item type explicitly on various resources (#438)

Author: Borgquite

CHANGELOG.md

@@ -30,6 +30,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   - Updated unit tests to use Should -Invoke for Pester 5 compatibility.
 - `VirtualMemory` fix incorrect variable name
 - `SmbServerConfiguration` remove errant argument
+- Update all calls to edit the registry so that the value Type is explicitly set.
+  Fixes [Issue #433](https://github.com/dsccommunity/ComputerManagementDsc/issues/433).
 
 ### Changed
 

source/DSCResources/DSC_IEEnhancedSecurityConfiguration/DSC_IEEnhancedSecurityConfiguration.psm1

@@ -134,6 +134,7 @@ function Set-TargetResource
                 Path = $registryKey
                 Name = $script:registryKey_Property
                 Value = $Enabled
+                Type = 'DWord'
                 ErrorAction = 'Stop'
             }
 

source/DSCResources/DSC_RemoteDesktopAdmin/DSC_RemoteDesktopAdmin.psm1

@@ -171,12 +171,28 @@ function Set-TargetResource
     if ($Ensure -ne $targetResource.Ensure)
     {
         Write-Verbose -Message ($script:localizedData.SettingRemoteDesktopAdminMessage -f $Ensure)
-        Set-ItemProperty -Path $script:tSRegistryKey -Name "fDenyTSConnections" -Value $fDenyTSConnectionsRegistry
+
+        $setItemPropertyParameters = @{
+            Path = $script:tSRegistryKey
+            Name = "fDenyTSConnections"
+            Value = $fDenyTSConnectionsRegistry
+            Type = 'DWord'
+        }
+
+        Set-ItemProperty @setItemPropertyParameters
     }
 
     if ($UserAuthentication -ne $targetResource.UserAuthentication)
     {
         Write-Verbose -Message ($script:localizedData.SettingUserAuthenticationMessage -f $UserAuthentication)
-        Set-ItemProperty -Path $script:winStationsRegistryKey -Name "UserAuthentication" -Value $UserAuthenticationRegistry
+
+        $setItemPropertyParameters = @{
+            Path = $script:winStationsRegistryKey
+            Name = "UserAuthentication"
+            Value = $UserAuthenticationRegistry
+            Type = 'DWord'
+        }
+
+        Set-ItemProperty @setItemPropertyParameters
     }
 }

source/DSCResources/DSC_WindowsEventLog/DSC_WindowsEventLog.psm1

@@ -899,8 +899,15 @@ function Set-WindowsEventLogRestrictGuestAccess
 
     try
     {
-        Set-ItemProperty -Path $logRegistryPath `
-            -Name 'RestrictGuestAccess' -Value $RestrictGuestAccess -ErrorAction Stop
+        $setItemPropertyParameters = @{
+            Path = $logRegistryPath
+            Name = 'RestrictGuestAccess'
+            Value = $RestrictGuestAccess
+            Type = 'DWord'
+            ErrorAction = 'Stop'
+        }
+
+        Set-ItemProperty @setItemPropertyParameters
     }
     catch
     {

tests/Integration/DSC_PendingReboot.Tests.ps1

@@ -59,10 +59,14 @@ AfterAll {
 
     if ($script:currentPendingFileRenameState)
     {
-        $null = Set-ItemProperty `
-            -Path $script:rebootRegistryKeys.PendingFileRename `
-            -Name PendingFileRenameOperations `
-            -Value $script:currentPendingFileRenameState
+        $setItemPropertyParameters = @{
+            Path = $script:rebootRegistryKeys.PendingFileRename
+            Name = 'PendingFileRenameOperations'
+            Value = $script:currentPendingFileRenameState
+            Type = 'MultiString'
+        }
+
+        $null = Set-ItemProperty @setItemPropertyParameters
     }
 }
 

tests/Unit/DSC_RemoteDesktopAdmin.Tests.ps1

@@ -384,7 +384,8 @@ Describe 'DSC_RemoteDesktopAdmin\Set-TargetResource' -Tag 'Set' {
 
                 Should -Invoke -CommandName Set-ItemProperty -ParameterFilter {
                     $Name -eq 'fDenyTSConnections' -and
-                    $Value -eq '0'
+                    $Value -eq '0' -and
+                    $Type -eq 'DWord'
                 } -Times 1 -Exactly -Scope It
             }
         }
@@ -408,7 +409,8 @@ Describe 'DSC_RemoteDesktopAdmin\Set-TargetResource' -Tag 'Set' {
 
                 Should -Invoke -CommandName Set-ItemProperty -ParameterFilter {
                     $Name -eq 'fDenyTSConnections' -and
-                    $Value -eq '1'
+                    $Value -eq '1' -and
+                    $Type -eq 'DWord'
                 } -Times 1 -Exactly -Scope It
             }
         }
@@ -433,7 +435,8 @@ Describe 'DSC_RemoteDesktopAdmin\Set-TargetResource' -Tag 'Set' {
 
                 Should -Invoke -CommandName Set-ItemProperty -ParameterFilter {
                     $Name -eq 'UserAuthentication' -and
-                    $Value -eq '1'
+                    $Value -eq '1' -and
+                    $Type -eq 'DWord'
                 } -Times 1 -Exactly -Scope It
             }
         }
@@ -458,7 +461,8 @@ Describe 'DSC_RemoteDesktopAdmin\Set-TargetResource' -Tag 'Set' {
 
                 Should -Invoke -CommandName Set-ItemProperty -ParameterFilter {
                     $Name -eq 'UserAuthentication' -and
-                    $Value -eq '0'
+                    $Value -eq '0' -and
+                    $Type -eq 'DWord'
                 } -Times 1 -Exactly -Scope It
             }
         }

tests/Unit/DSC_UserAccountControl.Tests.ps1

@@ -467,17 +467,20 @@ Describe 'UserAccountControl\Set-UserAccountControlToNotificationLevel' -Tag 'Pr
 
         Should -Invoke -CommandName Set-ItemProperty -ParameterFilter {
             $Name -eq 'ConsentPromptBehaviorAdmin' -and
-            $Value -eq $ConsentPromptBehaviorAdmin
+            $Value -eq $ConsentPromptBehaviorAdmin -and
+            $Type -eq 'DWord'
         } -Exactly -Times 1 -Scope It
 
         Should -Invoke -CommandName Set-ItemProperty -ParameterFilter {
             $Name -eq 'EnableLUA' -and
-            $Value -eq $EnableLua
+            $Value -eq $EnableLua -and
+            $Type -eq 'DWord'
         } -Exactly -Times 1 -Scope It
 
         Should -Invoke -CommandName Set-ItemProperty -ParameterFilter {
             $Name -eq 'PromptOnSecureDesktop' -and
-            $Value -eq $PromptOnSecureDesktop
+            $Value -eq $PromptOnSecureDesktop -and
+            $Type -eq 'DWord'
         } -Exactly -Times 1 -Scope It
     }